Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for a table wrapper capture #689

Open
muffinresearch opened this issue Jul 30, 2020 · 0 comments
Open

Remove the need for a table wrapper capture #689

muffinresearch opened this issue Jul 30, 2020 · 0 comments
Labels
blocks-l10n These issues block localizing the site enhancement New feature or request

Comments

@muffinresearch
Copy link
Contributor

muffinresearch commented Jul 30, 2020

Depending on the template this might be best resolved with a "fence" style markdown extension.

Here's an example of the current syntax:

{% capture table %}

| Parameter             | Description   | Example             |
| ------------------------------------- | ------------------- | -------------------------- |
| <em>utm_source</em>		| The name of the product, domain of the website that drives traffic to the link. | <em>utm_source=email</em> |
| <em>utm_medium</em> | The channel you are using to share your link.  | <em>utm_medium=social</em> |
| <em>utm_content</em> | The specific item that a person clicks on to access the link (such as an A/B test, a website banner, or a specific ad). | <em>utm_content=get-the-addon-button</em> |
| <em>utm_campaign</em> | The specific product promotion or strategic campaign. | <em>utm_campaign=launch-announcement</em> |

{% endcapture %}
{% include modules/table.liquid
	content: table
%}

All the template is doing is this:

<div class="table-wrapper table-scroll" markdown="1">

{{ content }}

</div>

If at all possible it would be nice to not need to do anything other than the markdown for a table.

@muffinresearch muffinresearch added the blocks-l10n These issues block localizing the site label Jul 30, 2020
@rebloor rebloor added the enhancement New feature or request label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks-l10n These issues block localizing the site enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants