Don't show delete button for workspaces in sidebar without sufficient permission

[naglepuff]

Potentially related to #140

We should probably hide the delete buttons in the sidebar for workspaces that the current user can not delete. The API prevents actual deletion so this is more of a UI change. It's potentially a bit more complicated than the (currently in progress) fix for #140, so I'm not going to attempt doing this as part of that fix.

I'm also wondering if we should remove this functionality altogether, and only allow workspace deletion from within the workspace detail view. I can see the potential for users to make mistakes, and accidentally delete the wrong workspace if multiple workspaces that they own have similar names.

[naglepuff]

@jtomeck Curious to hear your thoughts on the second paragraph there to get some UX expert opinions.

[waxlamp]

I think we could drop the delete action from the sidebar and have it be solely an action you take from inside the workspace context.

The only thing that would become harder to do is bulk deletion of several workspaces. We could still support that use case just by using the existing sidebar checkbox functionality, but to be honest I don't think we should spend time on making that work properly--we have other things that are higher impact that we can be doing.

(But I'd still like to hear Jared's thoughts on this.)

[jtomeck]

What happens in the API when deletion happens? Is it more of an archive feature? If so we might want to create a UI for that. I think the bulk deletion is really valuable. In this case it would be bulk archival, but I think it's necessary nonetheless.

If you guys disagree about it's importance I'd like to hear your thoughts. In that case I'd be fine with just removing it and putting it within the workspace only.

[waxlamp]

Right now, deletion actually deletes the workspaces. We have an issue filed somewhere about archival (which would essentially just add a flag to the workspace, along with logic for filtering out "archived" workspaces from usual operations, plus some way to unarchive them) but it has been low priority.

What about my hybrid approach for the moment, of removing the floating "delete" icon from the sidebar, but retaining the checkbox behavior for bulk delete? Then, individual deletion would be a more deliberate act requiring entry into the workspace to delete, and bulk deletion would remain deliberate since it requires clicking on several checkboxes before clicking on a bulk delete action.

[jtomeck]

What about my hybrid approach for the moment, of removing the floating "delete" icon from the sidebar, but retaining the checkbox behavior for bulk delete? Then, individual deletion would be a more deliberate act requiring entry into the workspace to delete, and bulk deletion would remain deliberate since it requires clicking on several checkboxes before clicking on a bulk delete action.

Let's do it. +1