Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to playlist to be added to folder menu in browse view (was Album cover vs. embedded cover) #3606

Open
1 task done
Swimmer71 opened this issue Feb 22, 2025 · 15 comments
Open
1 task done
Labels
enhancement Improvements of existing functionality

Comments

@Swimmer71
Copy link

Swimmer71 commented Feb 22, 2025

What version of Music Assistant has the issue?

2.4.0rc8 (I think starting from rc2)

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

  • Yes

The problem

From the discussion here:
https://github.com/orgs/music-assistant/discussions/3584#discussioncomment-12272421
I learned, that the album cover get priority over embedded cover, but the behavior is different:

Whenever the album ID3 tag is set, no embedded cover is shown at all, even if no album cover (cover.jpg) is available inside the folder. When I delete the album.jpg I expected to see the embedded covers.

In folder Music/Hits I have .mp3 with album tag "Hits" and cover.jpg
I play folder with music_assistant.play_media and media_id: filesystem_smb://folder/Music/Hits.
It shows me the cover.jpg for all songs.
When I delete cover.jpg --> no covers at all were shown
When I delete the album tag "Hits" --> embedded covers are shown (even tough I copy cover.jpg back)

So it seems, that the ID3 tag "album" determins if album or embedded cover is shown.

Wouldn't following behavior be better?:

If cover.jpg is available in folder --> show this for cover
If no cover.jpg available in folder --> show embedded covers (regardless wether ID3 tag album is empty or not)

OR (even better)
Introduce a "priority button" in settings for either embedded covers or for cover.jpg.

How to reproduce

I described above

Music Providers

local and SMB

Player Providers

I only have Chromecasts

Full log output

xxx

Additional information

I use minimediaplayer with MA-entity and UniversalMediaPlayer (UMP) entity with the MA-entity and AV-receiver combined, same behavior

What version of Home Assistant Core are your running

2025.2.5

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Alternative

@marcelveldt
Copy link
Member

Where is it shown or not shown ? Can you please make screenshots ?
Also check the MA interface if its displayed there. We need to know exactly where its missing because currently I cant reproduce this issue. Album cover is only preferred if there is actually an album cover.

@Swimmer71
Copy link
Author

OK, here more details.
Covers in MA and in Minimediaplayer are always displayed the same! So this works!
All my tracks have individual embedded covers!
I always want to play folders and not albums!

TEST1

So I have a folder Test1 which looks like:
Image
Image
"album" tag is empty
Just for testing I also put a cover.jpg into the folder.
Playing with "browse NAS folder...in MA" and with "music_assistant.play_media and media_id: filesystem_smb://folder/Test1" shows same result --> It shows the embedded covers inside MA and in Minimediaplayer
This is OK for me because I always want to see embedded covers (but I expected to see the cover.jpg as this is priority as I learned)

TEST2

My folder Test2 now has "album" tag filled with "Test2".
Image
Image
As long I have a cover.jpg inside the folder, it takes this one for all tracks --> this is the standard MA behavior as I learned.

But when I remove the cover.jpg (then I remove the album from library and start a rescan) I expected all embedded covers to be shown because of missing cover.jpg. Instead, it picked out one embedded cover (in this case it was from "Fly Away") and used this for all tracks.
Image

@Swimmer71
Copy link
Author

in other words:
als long as album tag is filled with something, it never shows embedded covers. It shows cover.jpg from album folder and if not available it picks up the cover from one song and uses this for all songs.
Better behavior: when cover.jpg is available --> use this and if not available --> use embedded

Playlist is simmilar:
All songs in PL with album tag shows the album cover, and all songs with empty album tag show embedded tags.
The PL itself has no cover (some releases ago I saw a PL cover with many tiny covers from the songs, but not any more)
Image

@marcelveldt
Copy link
Member

Either fill the album tag with the REAL album name or don't fill it al all. The fact that you set it to some random name like test on multiple files and also have a cover.jpg in the folder structure, messes everything up.

@Swimmer71
Copy link
Author

I don't mess everything! Just for analysis and demonstration I made 2 small albums (Test1 and Test2).
Test1 has cover.jpg inside the folder, so this is what user maybe do normally.
Test2 has no cover.jpg but embedded covers: here one embedded cover is picked out for the whole album and embedded are NOT shown. This behavior is different since around end of beta or beginning of the RCs.

How can I see embedded covers when album tag ist set and no cover.jpg is in folder? This was possible in former releases!

@marcelveldt
Copy link
Member

Please do not set "Test1" as album to multiple tracks. Just use the REAL album name or no album at all.
Because you set the fake "test 1" (or test 2 etc) as album on multiple tracks, the system links that as actual album to the tracks and attaches the first embedded cover as album cover.

So if you simply use the correct album name as tag, it will work

@marcelveldt
Copy link
Member

Did you check if assigning an actual album per track solves the issue ?

@Swimmer71
Copy link
Author

Swimmer71 commented Feb 26, 2025 via email

@OzGav
Copy link
Contributor

OzGav commented Feb 26, 2025

Marcel means properly tag these tracks with their actual album name. You are working against the usual practice of tagging tracks and having them in a folder by album but it should still work.

@Swimmer71
Copy link
Author

Swimmer71 commented Feb 26, 2025 via email

@marcelveldt
Copy link
Member

So I don't say this is working wrong, but it worked with the album and individual covers some version before. But ok, it is what it is.

Well it worked before but that caused other bugs. So please use the album field for what it is intended. If you abuse it for something else, don't act surprised that the software will not accept that ;-)

Maybe Genre Tag will come one day

We already read genre tags and one of the next releases will bring sophisticated genre filterings, just a little bit more patient...

or adding a folder to a playlist will also make life easier

Actually, the backend already supports that. Later this week I'll check if I can add that quickly to the frontend. Shouldnt be too much work. For now, you can play folders, did you already discover that ?

@Swimmer71
Copy link
Author

Swimmer71 commented Feb 26, 2025 via email

@OzGav OzGav added enhancement Improvements of existing functionality and removed triage More info labels Mar 5, 2025
@Swimmer71
Copy link
Author

Hi,
any plan for adding "genre" and "adding folder" for playlist?

Maybe Genre Tag will come one day

We already read genre tags and one of the next releases will bring sophisticated genre filterings, just a little bit more patient...

or adding a folder to a playlist will also make life easier

Actually, the backend already supports that. Later this week I'll check if I can add that quickly to the frontend. Shouldnt be too much work. For now, you can play folders, did you already discover that ?

@OzGav
Copy link
Contributor

OzGav commented Mar 14, 2025

Marcel already said genre filtering will come sometime in the next releases.

@Swimmer71
Copy link
Author

Ok, so I am waiting for "Genre" feature patiently ;-)

I just asked for "Adding Folder to playlist" because Marcel said, that the backend is already prepared and "later this week" (3 weeks ago) he wants to have a look on it if easy possible for frontend.
But I know, there is a lot of work to do with those other bugfixes before...Thanks for the great work!

@OzGav OzGav changed the title Album cover vs. embedded cover Ad to playlist to be added to folder menu in browse view (was Album cover vs. embedded cover) Apr 2, 2025
@OzGav OzGav changed the title Ad to playlist to be added to folder menu in browse view (was Album cover vs. embedded cover) Add to playlist to be added to folder menu in browse view (was Album cover vs. embedded cover) Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements of existing functionality
Projects
Status: NEXT
Development

No branches or pull requests

3 participants