Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-Peer Review - M2W4 #7

Open
ahangarha opened this issue Mar 4, 2022 · 1 comment
Open

Peer-to-Peer Review - M2W4 #7

ahangarha opened this issue Mar 4, 2022 · 1 comment

Comments

@ahangarha
Copy link

Thank you for sharing your code. We just noticed some minor issues as listed below:

  • Currently there is no indication of any error if user submit empty form. It is good that on js part, you don't add empty records to the board but it is good to give some indication to the user to understand the issue.
  • It would be better to add required attribute to input fields in the form to prevent empty field submission
  • It seems you didn't use gitflow. Please make sure each new featur branch is made from develop branch. This means after merging the PR to develop, pull the latest changes on you local clone (on develop branch) and then make a new branch from there
  • It is good that you made the project responsive. Just it would be good to add some padding to the form section so the the title and the button have some distance from edges.

All the bests

@mwafrika
Copy link
Owner

mwafrika commented Mar 4, 2022

Thank you so much @ahangarha for addressing these issues, I take note and improve next time in the projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants