move weekDayScheduleInStorage yearDayScheduleInStorage holidayScheduleInStorage from class members to local function variables

Author: mykrupp

examples/lock-app/silabs/include/LockManager.h

@@ -302,9 +302,6 @@ class LockManager
 
     LockUserInfo userInStorage;
     LockCredentialInfo credentialInStorage;
-    WeekDayScheduleInfo weekDayScheduleInStorage;
-    YearDayScheduleInfo yearDayScheduleInStorage;
-    HolidayScheduleInfo holidayScheduleInStorage;
     CredentialStruct mCredentials[kMaxCredentialsPerUser];
 };
 

examples/lock-app/silabs/src/LockManager.cpp

@@ -616,6 +616,8 @@ DlStatus LockManager::GetWeekdaySchedule(chip::EndpointId endpointId, uint8_t we
 {
     CHIP_ERROR error;
 
+    WeekDayScheduleInfo weekDayScheduleInStorage;
+
     VerifyOrReturnValue(kInvalidEndpointId != endpointId, DlStatus::kFailure);
 
     VerifyOrReturnValue(weekdayIndex > 0, DlStatus::kFailure); // indices are one-indexed
@@ -667,6 +669,8 @@ DlStatus LockManager::SetWeekdaySchedule(chip::EndpointId endpointId, uint8_t we
 {
     CHIP_ERROR error;
 
+    WeekDayScheduleInfo weekDayScheduleInStorage;
+
     VerifyOrReturnValue(kInvalidEndpointId != endpointId, DlStatus::kFailure);
 
     VerifyOrReturnValue(weekdayIndex > 0, DlStatus::kFailure); // indices are one-indexed
@@ -705,6 +709,8 @@ DlStatus LockManager::GetYeardaySchedule(chip::EndpointId endpointId, uint8_t ye
 {
     CHIP_ERROR error;
 
+    YearDayScheduleInfo yearDayScheduleInStorage;
+
     VerifyOrReturnValue(kInvalidEndpointId != endpointId, DlStatus::kFailure);
 
     VerifyOrReturnValue(yearDayIndex > 0, DlStatus::kFailure); // indices are one-indexed
@@ -755,6 +761,8 @@ DlStatus LockManager::SetYeardaySchedule(chip::EndpointId endpointId, uint8_t ye
 {
     CHIP_ERROR error;
 
+    YearDayScheduleInfo yearDayScheduleInStorage;
+
     VerifyOrReturnValue(kInvalidEndpointId != endpointId, DlStatus::kFailure);
 
     VerifyOrReturnValue(yearDayIndex > 0, DlStatus::kFailure); // indices are one-indexed
@@ -790,6 +798,8 @@ DlStatus LockManager::GetHolidaySchedule(chip::EndpointId endpointId, uint8_t ho
 {
     CHIP_ERROR error;
 
+    HolidayScheduleInfo holidayScheduleInStorage;
+
     VerifyOrReturnValue(kInvalidEndpointId != endpointId, DlStatus::kFailure);
 
     VerifyOrReturnValue(holidayIndex > 0, DlStatus::kFailure); // indices are one-indexed
@@ -837,6 +847,8 @@ DlStatus LockManager::SetHolidaySchedule(chip::EndpointId endpointId, uint8_t ho
 {
     CHIP_ERROR error;
 
+    HolidayScheduleInfo holidayScheduleInStorage;
+
     VerifyOrReturnValue(kInvalidEndpointId != endpointId, DlStatus::kFailure);
 
     VerifyOrReturnValue(holidayIndex > 0, DlStatus::kFailure); // indices are one-indexed