* fix some violations of Roslyn analyzer rules

n0099 · n0099 · commit 10304cd7c11e · 2024-03-26T21:11:55.000+08:00
* level up `AnalysisMode` and enable `EnforceCodeStyleInBuild` @ Directory.Build.props
* suppress other violations of Roslyn analyzer rules @ GlobalSuppressions.cs
@ c#
diff --git a/c#/.editorconfig b/c#/.editorconfig
@@ -81,7 +81,7 @@ dotnet_naming_rule.constants_rule.import_to_resharper = as_predefined
 dotnet_naming_rule.constants_rule.severity = warning
 dotnet_naming_rule.constants_rule.style = upper_camel_case_style
 dotnet_naming_rule.constants_rule.symbols = constants_symbols
-dotnet_naming_rule.constant_fields_should_be_pascal_case_rule.import_to_resharper = True
+dotnet_naming_rule.constant_fields_should_be_pascal_case_rule.import_to_resharper = true
 dotnet_naming_rule.constant_fields_should_be_pascal_case_rule.resharper_description = constant_fields_should_be_pascal_case
 dotnet_naming_rule.constant_fields_should_be_pascal_case_rule.severity = suggestion
 dotnet_naming_rule.constant_fields_should_be_pascal_case_rule.style = upper_camel_case_style
diff --git a/c#/Directory.Build.props b/c#/Directory.Build.props
@@ -8,6 +8,8 @@
         <PathMap>$(MSBuildProjectDirectory)=/</PathMap>
         <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
+        <AnalysisMode>Recommended</AnalysisMode>
+        <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     </PropertyGroup>
     <ItemGroup>
         <AdditionalFiles Include="$(MSBuildThisFileDirectory)\stylecop.json" />
diff --git a/c#/GlobalSuppressions.cs b/c#/GlobalSuppressions.cs
@@ -43,6 +43,17 @@
 [assembly: SuppressMessage("Style", "CC0001:You should use 'var' whenever possible.")]
 [assembly: SuppressMessage("Style", "CC0037:Remove commented code.")]
 [assembly: SuppressMessage("Documentation", "AV2305:Missing XML comment for internally visible type, member or parameter")]
+[assembly: SuppressMessage("Style", "CC0061:Asynchronous method can be terminated with the 'Async' keyword.")]
+[assembly: SuppressMessage("Style", "MA0003:Add parameter name to improve readability")]
+[assembly: SuppressMessage("Style", "MA0007:Add a comma after the last value")]
+[assembly: SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods")]
+[assembly: SuppressMessage("Usage", "MA0004:Use Task.ConfigureAwait")]
+[assembly: SuppressMessage("Usage", "MA0006:Use String.Equals instead of equality operator")]
+[assembly: SuppressMessage("Usage", "MA0015:Specify the parameter name in ArgumentException")]
+[assembly: SuppressMessage("Performance", "CA1848:Use the LoggerMessage delegates")]
+[assembly: SuppressMessage("Usage", "CC0057:Unused parameters")]
+[assembly: SuppressMessage("Naming", "CA1711:Identifiers should not have incorrect suffix")]
+[assembly: SuppressMessage("Naming", "CA1716:Identifiers should not match keywords")]
 
 [assembly: SuppressMessage("StyleCop.CSharp.ReadabilityRules", "SA1101:Prefix local calls with this")]
 [assembly: SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1600:Elements should be documented")]
diff --git a/c#/crawler/src/Db/ProtoBufRepeatedFieldJsonConverter.cs b/c#/crawler/src/Db/ProtoBufRepeatedFieldJsonConverter.cs
@@ -5,7 +5,7 @@ public class ProtoBufRepeatedFieldJsonConverter<TProtoBuf>
 {
     public override RepeatedField<TProtoBuf> Read
         (ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) =>
-        throw new NotImplementedException();
+        throw new NotSupportedException();
 
     public override void Write
         (Utf8JsonWriter writer, RepeatedField<TProtoBuf> value, JsonSerializerOptions options) =>
diff --git a/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs b/c#/crawler/src/Db/Revision/RevisionWithSplitting.cs
@@ -7,7 +7,7 @@ public abstract class RevisionWithSplitting<TBaseRevision> : IRevision
     public ushort? NullFieldsBitMask { get; set; }
     public Dictionary<Type, TBaseRevision> SplitEntities { get; } = [];
 
-    public virtual bool IsAllFieldsIsNullExceptSplit() => throw new NotImplementedException();
+    public virtual bool IsAllFieldsIsNullExceptSplit() => throw new NotSupportedException();
 
     protected TValue? GetSplitEntityValue<TSplitEntity, TValue>
         (Func<TSplitEntity, TValue?> valueSelector)
diff --git a/c#/crawler/src/Tieba/Crawl/Saver/BaseSaver.cs b/c#/crawler/src/Tieba/Crawl/Saver/BaseSaver.cs
@@ -15,7 +15,7 @@ public abstract class BaseSaver<TPost, TBaseRevision>(
     protected event PostSaveEventHandler PostSaveEvent = () => { };
 
     public virtual FieldChangeIgnoranceDelegates UserFieldChangeIgnorance =>
-        throw new NotImplementedException();
+        throw new NotSupportedException();
     public string PostType { get; } = postType;
     protected ConcurrentDictionary<ulong, TPost> Posts { get; } = posts;
     protected AuthorRevisionSaver AuthorRevisionSaver { get; } = authorRevisionSaverFactory(postType);
diff --git a/c#/crawler/src/Tieba/Crawl/Saver/CommonInSavers.cs b/c#/crawler/src/Tieba/Crawl/Saver/CommonInSavers.cs
@@ -9,7 +9,7 @@ public abstract class CommonInSavers<TBaseRevision>(ILogger<CommonInSavers<TBase
     protected delegate void RevisionUpsertDelegate(CrawlerDbContext db, IEnumerable<TBaseRevision> revision);
 
     protected virtual Dictionary<Type, RevisionUpsertDelegate>
-        RevisionUpsertDelegatesKeyBySplitEntityType => throw new NotImplementedException();
+        RevisionUpsertDelegatesKeyBySplitEntityType => throw new NotSupportedException();
 
     protected void SavePostsOrUsers<TPostOrUser, TRevision>(
         CrawlerDbContext db,
@@ -109,7 +109,7 @@ bool IsTimestampingFieldName(string name) => name is nameof(IPost.LastSeenAt)
             .ForEach(g => RevisionUpsertDelegatesKeyBySplitEntityType[g.Key](db, g));
     }
 
-    protected virtual NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => throw new NotImplementedException();
+    protected virtual NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => throw new NotSupportedException();
 
     private static bool IsLatestReplierUser(string pName, PropertyEntry p, EntityEntry entry)
     {
diff --git a/c#/crawler/src/Tieba/Crawl/UserParserAndSaver.cs b/c#/crawler/src/Tieba/Crawl/UserParserAndSaver.cs
@@ -45,7 +45,7 @@ public void ParseUsers(IEnumerable<TbClient.User> users) =>
         {
             static (string Portrait, uint? UpdateTime) ExtractPortrait(string portrait) =>
                 ExtractPortraitRegex().Match(portrait) is {Success: true} m
-                    ? (m.Groups[1].Value, Time.Parse(m.Groups[2].ValueSpan))
+                    ? (m.Groups["portrait"].Value, Time.Parse(m.Groups["timestamp"].ValueSpan))
                     : (portrait, null);
 
             var uid = el.Uid;
@@ -132,6 +132,6 @@ public void PostSaveHook()
         lock (UserIdLocks) if (_savedUsersId.Count != 0) UserIdLocks.ExceptWith(_savedUsersId);
     }
 
-    [GeneratedRegex("^(.+)\\?t=([0-9]+)$", RegexOptions.Compiled, matchTimeoutMilliseconds: 100)]
+    [GeneratedRegex("^(?<portrait>.+)\\?t=(?<timestamp>[0-9]+)$", RegexOptions.Compiled, matchTimeoutMilliseconds: 100)]
     private static partial Regex ExtractPortraitRegex();
 }
diff --git a/c#/crawler/src/Worker/ArchiveCrawlWorker.cs b/c#/crawler/src/Worker/ArchiveCrawlWorker.cs
@@ -23,7 +23,7 @@ public class ArchiveCrawlWorker(
     private readonly string _forumName = "";
 
     // ReSharper disable once ConvertToConstant.Local
-    private readonly Fid _fid = 0;
+    private readonly Fid _fid = 1;
 
     // https://en.wikipedia.org/wiki/Moving_average#Cumulative_average
     public static float GetCumulativeAverage(float currentCa, float previousCa, int currentIndex) =>
diff --git a/c#/crawler/src/Worker/ForumModeratorRevisionCrawlWorker.cs b/c#/crawler/src/Worker/ForumModeratorRevisionCrawlWorker.cs
@@ -88,10 +88,10 @@ from rev in db.ForumModeratorRevisions.AsNoTracking()
                 }).Where(e => e.Rank == 1)
             .ToLinqToDB().ToList();
 
-        db.ForumModeratorRevisions.AddRange(revisions.ExceptBy(
+        await db.ForumModeratorRevisions.AddRangeAsync(revisions.ExceptBy(
             existingLatestRevisions.Select(e => (e.Portrait, e.ModeratorTypes)),
-            rev => (rev.Portrait, rev.ModeratorTypes)));
-        db.ForumModeratorRevisions.AddRange(existingLatestRevisions
+            rev => (rev.Portrait, rev.ModeratorTypes)), stoppingToken);
+        await db.ForumModeratorRevisions.AddRangeAsync(existingLatestRevisions
 
             // filter out revisions that recorded someone who resigned from moderators
             .Where(e => e.ModeratorTypes != "")
@@ -102,7 +102,7 @@ from rev in db.ForumModeratorRevisions.AsNoTracking()
                 Fid = fid,
                 Portrait = e.Portrait,
                 ModeratorTypes = "" // moderator only exists in DB means the user is no longer a moderator
-            }));
+            }), stoppingToken);
 
         _ = await db.SaveChangesAsync(stoppingToken);
         await transaction.CommitAsync(stoppingToken);
diff --git a/c#/imagePipeline/src/Consumer/HashConsumer.cs b/c#/imagePipeline/src/Consumer/HashConsumer.cs
@@ -8,6 +8,7 @@ public sealed class HashConsumer : MatrixConsumer, IDisposable
     private readonly FailedImageHandler _failedImageHandler;
     private readonly Dictionary<ImgHashBase, Action<ImageHash, byte[]>> _imageHashSettersKeyByAlgorithm;
 
+    [SuppressMessage("Correctness", "SS004:Implement Equals() and GetHashcode() methods for a type used in a collection.")]
     public HashConsumer(FailedImageHandler failedImageHandler)
     {
         _failedImageHandler = failedImageHandler;
diff --git a/c#/imagePipeline/src/Consumer/IConsumer.cs b/c#/imagePipeline/src/Consumer/IConsumer.cs
@@ -4,6 +4,6 @@ public interface IConsumer<in T>
 {
     public (IEnumerable<ImageId> Failed, IEnumerable<ImageId> Consumed) Consume(
         ImagePipelineDbContext db,
-        IReadOnlyCollection<T> imageKeysWithMatrix,
+        IReadOnlyCollection<T> imageKeysWithT,
         CancellationToken stoppingToken = default);
 }
diff --git a/c#/imagePipeline/src/Consumer/MatrixConsumer.cs b/c#/imagePipeline/src/Consumer/MatrixConsumer.cs
@@ -4,12 +4,12 @@ public abstract class MatrixConsumer : IConsumer<ImageKeyWithMatrix>
 {
     public (IEnumerable<ImageId> Failed, IEnumerable<ImageId> Consumed) Consume(
         ImagePipelineDbContext db,
-        IReadOnlyCollection<ImageKeyWithMatrix> imageKeysWithMatrix,
+        IReadOnlyCollection<ImageKeyWithMatrix> imageKeysWithT,
         CancellationToken stoppingToken = default)
     {
         // defensive clone to prevent any consumer mutate the original matrix given in param
         var clonedImageKeysWithMatrix =
-            imageKeysWithMatrix.Select(i => i with {Matrix = i.Matrix.Clone()}).ToList();
+            imageKeysWithT.Select(i => i with {Matrix = i.Matrix.Clone()}).ToList();
         try
         {
             var failed = ConsumeInternal(db, clonedImageKeysWithMatrix, stoppingToken).ToList();
diff --git a/c#/imagePipeline/src/Consumer/MetadataConsumer.cs b/c#/imagePipeline/src/Consumer/MetadataConsumer.cs
@@ -40,17 +40,17 @@ ulong[] GetCommonXxHash3ToIgnore(string key) =>
 
     public (IEnumerable<ImageId> Failed, IEnumerable<ImageId> Consumed) Consume(
         ImagePipelineDbContext db,
-        IReadOnlyCollection<ImageWithBytes> imagesWithBytes,
+        IReadOnlyCollection<ImageWithBytes> imageKeysWithT,
         CancellationToken stoppingToken = default)
     {
         var metadataEithers = _failedImageHandler
-            .TrySelect(imagesWithBytes,
+            .TrySelect(imageKeysWithT,
                 imageWithBytes => imageWithBytes.ImageInReply.ImageId,
                 GetImageMetaData(stoppingToken))
             .ToList();
         db.ImageMetadata.AddRange(metadataEithers.Rights());
         var failed = metadataEithers.Lefts().ToList();
-        return (failed, imagesWithBytes.Select(i => i.ImageInReply.ImageId).Except(failed));
+        return (failed, imageKeysWithT.Select(i => i.ImageInReply.ImageId).Except(failed));
     }
 
     private Func<ImageWithBytes, ImageMetadata> GetImageMetaData
@@ -299,7 +299,7 @@ private static partial class ExifDateTimeTagValuesParser
 
         [GeneratedRegex(
             "^.*(?<dateTime>[0-9]{4}:[0-9]{2}:[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}(?!(上|下)午)?).*$",
-            RegexOptions.Compiled, matchTimeoutMilliseconds: 100)]
+            RegexOptions.Compiled | RegexOptions.ExplicitCapture, matchTimeoutMilliseconds: 100)]
         private static partial Regex ExtractCommonExifDateTimeWithLeadingOrTrailingCharsRegex();
 
         [SuppressMessage("StyleCop.CSharp.SpacingRules", "SA1025:Code should not contain multiple whitespace in a row")]
diff --git a/c#/imagePipeline/src/ImageBatchConsumingWorker.cs b/c#/imagePipeline/src/ImageBatchConsumingWorker.cs
@@ -73,11 +73,11 @@ void MarkImagesInReplyAsConsumed
                 .ForEach(entry => entry.Property(selector).CurrentValue = true);
 
         logger.LogTrace("Start to consume {} image(s): [{}]",
-            imagesWithBytes.Count, string.Join(",", imagesInReply.Select(i => i.ImageId)));
+            imagesWithBytes.Count, string.Join(',', imagesInReply.Select(i => i.ImageId)));
         var sw = new Stopwatch();
         void LogStopwatch(string consumerType, IReadOnlyCollection<ImageId> imagesId) =>
             logger.LogTrace("Spend {}ms to {} for {} image(s): [{}]",
-                sw.ElapsedMilliseconds, consumerType, imagesId.Count, string.Join(",", imagesId));
+                sw.ElapsedMilliseconds, consumerType, imagesId.Count, string.Join(',', imagesId));
 
         void ConsumeConsumer<TImage, TConsumer>(
             Expression<Func<ImageInReply, bool>> selector, IReadOnlyCollection<TImage> images,
@@ -96,7 +96,7 @@ void ConsumeConsumer<TImage, TConsumer>(
 
             if (failed.Count == 0) return;
             logger.LogError("Failed to {} for {} image(s): [{}]",
-                consumerType, failed.Count, string.Join(",", failed));
+                consumerType, failed.Count, string.Join(',', failed));
         }
 
         ConsumeConsumer(i => i.MetadataConsumed,
@@ -243,9 +243,9 @@ where imageKeysWithMatrix
                     .ExceptBy(recognizedTextLines.Select(i => i.ImageId), i => i.ImageId).ToList();
 
                 // insert their previously recognized lines into the table of current forum and script
-                db.ImageOcrLines.AddRange(recognizedTextLines.IntersectBy(
+                await db.ImageOcrLines.AddRangeAsync(recognizedTextLines.IntersectBy(
                     imagesInCurrentFid.Except(uniqueImagesInCurrentFid).Select(i => i.ImageId),
-                    i => i.ImageId));
+                    i => i.ImageId), stoppingToken);
                 recognizedTextLines.AddRange(await ConsumeByFidAndScript(db, fid, script, uniqueImagesInCurrentFid));
                 _ = await db.SaveChangesAsync(stoppingToken);
             }
@@ -272,10 +272,10 @@ async Task<IEnumerable<ImageOcrLine>> ConsumeByFidAndScript(
             var failed = imagesId.Failed.ToList();
             if (failed.Count != 0)
                 logger.LogError("Failed to detect and recognize {} script text for fid {} in {} image(s): [{}]",
-                    script, fid, failed.Count, string.Join(",", failed));
+                    script, fid, failed.Count, string.Join(',', failed));
             logger.LogTrace("Spend {}ms to detect and recognize {} script text for fid {} in {} image(s): [{}]",
                 sw.ElapsedMilliseconds, script, fid, imagesInCurrentFid.Count,
-                string.Join(",", imagesInCurrentFid.Select(i => i.ImageId)));
+                string.Join(',', imagesInCurrentFid.Select(i => i.ImageId)));
 
             return ocrConsumer.RecognizedTextLines;
         }
diff --git a/c#/shared/src/TbmDbContext.cs b/c#/shared/src/TbmDbContext.cs
@@ -67,6 +67,7 @@ public class TbmDbContext<TModelCacheKeyFactory> : TbmDbContext
     public DbSet<ImageInReply> ImageInReplies => Set<ImageInReply>();
     public DbSet<ReplyContentImage> ReplyContentImages => Set<ReplyContentImage>();
 
+    [SuppressMessage("Naming", "CA1725:Parameter names should match base declaration")]
     [SuppressMessage("Critical Code Smell", "S927:Parameter names should match base declaration and other partial definitions")]
     [SuppressMessage("Style", "IDE0058:Expression value is never used")]
     protected override void OnConfiguring(DbContextOptionsBuilder options)
@@ -88,6 +89,7 @@ protected override void OnConfiguring(DbContextOptionsBuilder options)
         if (dbSettings.GetValue("EnableSensitiveDataLogging", false)) options.EnableSensitiveDataLogging();
     }
 
+    [SuppressMessage("Naming", "CA1725:Parameter names should match base declaration")]
     [SuppressMessage("Critical Code Smell", "S927:Parameter names should match base declaration and other partial definitions")]
     [SuppressMessage("Style", "IDE0058:Expression value is never used")]
     protected override void OnModelCreating(ModelBuilder b)

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ public class ProtoBufRepeatedFieldJsonConverter<TProtoBuf>`
`5`	`5`	`{`
`6`	`6`	`public override RepeatedField<TProtoBuf> Read`
`7`	`7`	`(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) =>`
`8`		`- throw new NotImplementedException();`
	`8`	`+ throw new NotSupportedException();`
`9`	`9`
`10`	`10`	`public override void Write`
`11`	`11`	`(Utf8JsonWriter writer, RepeatedField<TProtoBuf> value, JsonSerializerOptions options) =>`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public abstract class CommonInSavers<TBaseRevision>(ILogger<CommonInSavers<TBase`
`9`	`9`	`protected delegate void RevisionUpsertDelegate(CrawlerDbContext db, IEnumerable<TBaseRevision> revision);`
`10`	`10`
`11`	`11`	`protected virtual Dictionary<Type, RevisionUpsertDelegate>`
`12`		`- RevisionUpsertDelegatesKeyBySplitEntityType => throw new NotImplementedException();`
	`12`	`+ RevisionUpsertDelegatesKeyBySplitEntityType => throw new NotSupportedException();`
`13`	`13`
`14`	`14`	`protected void SavePostsOrUsers<TPostOrUser, TRevision>(`
`15`	`15`	`CrawlerDbContext db,`
`@@ -109,7 +109,7 @@ bool IsTimestampingFieldName(string name) => name is nameof(IPost.LastSeenAt)`
`109`	`109`	`.ForEach(g => RevisionUpsertDelegatesKeyBySplitEntityType[g.Key](db, g));`
`110`	`110`	`}`
`111`	`111`
`112`		`- protected virtual NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => throw new NotImplementedException();`
	`112`	`+ protected virtual NullFieldsBitMask GetRevisionNullFieldBitMask(string fieldName) => throw new NotSupportedException();`
`113`	`113`
`114`	`114`	`private static bool IsLatestReplierUser(string pName, PropertyEntry p, EntityEntry entry)`
`115`	`115`	`{`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public void ParseUsers(IEnumerable<TbClient.User> users) =>`
`45`	`45`	`{`
`46`	`46`	`static (string Portrait, uint? UpdateTime) ExtractPortrait(string portrait) =>`
`47`	`47`	`ExtractPortraitRegex().Match(portrait) is {Success: true} m`
`48`		`- ? (m.Groups[1].Value, Time.Parse(m.Groups[2].ValueSpan))`
	`48`	`+ ? (m.Groups["portrait"].Value, Time.Parse(m.Groups["timestamp"].ValueSpan))`
`49`	`49`	`: (portrait, null);`
`50`	`50`
`51`	`51`	`var uid = el.Uid;`
`@@ -132,6 +132,6 @@ public void PostSaveHook()`
`132`	`132`	`lock (UserIdLocks) if (_savedUsersId.Count != 0) UserIdLocks.ExceptWith(_savedUsersId);`
`133`	`133`	`}`
`134`	`134`
`135`		`- [GeneratedRegex("^(.+)\\?t=([0-9]+)$", RegexOptions.Compiled, matchTimeoutMilliseconds: 100)]`
	`135`	`+ [GeneratedRegex("^(?<portrait>.+)\\?t=(?<timestamp>[0-9]+)$", RegexOptions.Compiled, matchTimeoutMilliseconds: 100)]`
`136`	`136`	`private static partial Regex ExtractPortraitRegex();`
`137`	`137`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ public sealed class HashConsumer : MatrixConsumer, IDisposable`
`8`	`8`	`private readonly FailedImageHandler _failedImageHandler;`
`9`	`9`	`private readonly Dictionary<ImgHashBase, Action<ImageHash, byte[]>> _imageHashSettersKeyByAlgorithm;`
`10`	`10`
	`11`	`+ [SuppressMessage("Correctness", "SS004:Implement Equals() and GetHashcode() methods for a type used in a collection.")]`
`11`	`12`	`public HashConsumer(FailedImageHandler failedImageHandler)`
`12`	`13`	`{`
`13`	`14`	`_failedImageHandler = failedImageHandler;`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@ public interface IConsumer<in T>`
`4`	`4`	`{`
`5`	`5`	`public (IEnumerable<ImageId> Failed, IEnumerable<ImageId> Consumed) Consume(`
`6`	`6`	`ImagePipelineDbContext db,`
`7`		`- IReadOnlyCollection<T> imageKeysWithMatrix,`
	`7`	`+ IReadOnlyCollection<T> imageKeysWithT,`
`8`	`8`	`CancellationToken stoppingToken = default);`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,12 +4,12 @@ public abstract class MatrixConsumer : IConsumer<ImageKeyWithMatrix>`
`4`	`4`	`{`
`5`	`5`	`public (IEnumerable<ImageId> Failed, IEnumerable<ImageId> Consumed) Consume(`
`6`	`6`	`ImagePipelineDbContext db,`
`7`		`- IReadOnlyCollection<ImageKeyWithMatrix> imageKeysWithMatrix,`
	`7`	`+ IReadOnlyCollection<ImageKeyWithMatrix> imageKeysWithT,`
`8`	`8`	`CancellationToken stoppingToken = default)`
`9`	`9`	`{`
`10`	`10`	`// defensive clone to prevent any consumer mutate the original matrix given in param`
`11`	`11`	`var clonedImageKeysWithMatrix =`
`12`		`- imageKeysWithMatrix.Select(i => i with {Matrix = i.Matrix.Clone()}).ToList();`
	`12`	`+ imageKeysWithT.Select(i => i with {Matrix = i.Matrix.Clone()}).ToList();`
`13`	`13`	`try`
`14`	`14`	`{`
`15`	`15`	`var failed = ConsumeInternal(db, clonedImageKeysWithMatrix, stoppingToken).ToList();`