* fix throwing InvalidCastException: Unable to cast object of type 'System.Linq.Expressions.FieldExpression' to type 'System.Linq.Expressions.LambdaExpression'. at LinqToDB.Linq.Builder.ExpressionBuilder.ConvertSelect() when enumerating variable existingRevisionOfExistingUsers @ AuthorRevisionSaver.Save()

* rename variable and fields with name `ids` to full form plural nouns with suffix `-Id`
@ c#/crawler

Author: n0099

c#/crawler/src/Tieba/Crawl/Saver/Related/AuthorRevisionSaver.cs

@@ -55,9 +55,9 @@ private Action Save<TEntity, TRevision, TValue>(
             revisioningFieldSelector);
 
         SharedHelper.GetNowTimestamp(out var now);
+        var usersId = uniqueEntities.Select(uidSelector);
         var existingRevisionOfExistingUsers = dbSet.AsNoTracking()
-            .Where(e => e.Fid == db.Fid
-                        && uniqueEntities.Select(uidSelector).Contains(e.Uid))
+            .Where(e => e.Fid == db.Fid && usersId.Contains(e.Uid))
             .Select(latestRevisionProjectionFactory)
             .AsCte() // https://stackoverflow.com/questions/49854322/usage-of-for-update-in-window-function-postgres#comment86726589_49854322
             .Where(e => e.Rank == 1)

c#/crawler/src/Tieba/Crawl/Saver/Related/ThreadLatestReplierSaver.cs

@@ -6,12 +6,12 @@ public class ThreadLatestReplierSaver(
     SaverLocks<Tid>.New tidSaverLocksFactory)
 {
     private static readonly HashSet<UniqueLatestReplier> GlobalLockedLatestRepliers = [];
-    private static readonly HashSet<Tid> GlobalLockedTids = [];
+    private static readonly HashSet<Tid> GlobalLockedThreadsId = [];
 
     private readonly Lazy<SaverLocks<UniqueLatestReplier>> _latestReplierSaverLocks =
         new(() => latestReplierSaverLocksFactory(GlobalLockedLatestRepliers));
     private readonly Lazy<SaverLocks<Tid>> _tidSaverLocks =
-        new(() => tidSaverLocksFactory(GlobalLockedTids));
+        new(() => tidSaverLocksFactory(GlobalLockedThreadsId));
 
     public Action SaveFromThread(CrawlerDbContext db, IReadOnlyCollection<ThreadPost> threads)
     {

c#/crawler/src/Worker/RetryCrawlWorker.cs

@@ -60,18 +60,18 @@ private async Task RetryThreadLate(
         CancellationToken stoppingToken = default)
     {
         await using var threadLateFacade = threadLateCrawlFacadeFactory();
-        foreach (var tidsGroupByFid in failureCountWithPagesKeyByLockId
+        foreach (var threadsIdGroupByFid in failureCountWithPagesKeyByLockId
                      .Keys.GroupBy(lockId => lockId.Fid, lockId => lockId.Tid))
         {
-            var fid = tidsGroupByFid.Key;
+            var fid = threadsIdGroupByFid.Key;
             FailureCount FailureCountSelector(Tid tid) =>
 
                 // it should always contain only one page which is 1
                 failureCountWithPagesKeyByLockId[new(fid, tid)].Single().Value;
-            var failureCountsKeyByTid = tidsGroupByFid
+            var failureCountsKeyByTid = threadsIdGroupByFid
                 .Cast<Tid>().ToDictionary(tid => tid, FailureCountSelector);
             logger.LogTrace("Retrying previous failed thread late crawl with fid={}, threadsId={}",
-                fid, SharedHelper.UnescapedJsonSerialize(tidsGroupByFid));
+                fid, SharedHelper.UnescapedJsonSerialize(threadsIdGroupByFid));
             await threadLateFacade.Value(fid).CrawlThenSave(failureCountsKeyByTid, stoppingToken);
         }
     }