Skip to content

JsonSerializable class is missing virtual base destructor #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BrianSipos opened this issue Oct 10, 2023 · 1 comment
Open

JsonSerializable class is missing virtual base destructor #49

BrianSipos opened this issue Oct 10, 2023 · 1 comment

Comments

@BrianSipos
Copy link

The class JsonSerializable is a virtual base class but it is missing its virtual destructor function. This can cause derived classes to fail to clean up properly because of unspecified behavior.
@T-recks
Copy link
Contributor

T-recks commented Oct 19, 2023

Thanks for catching this. It's now resolved in our internal repository and will be pushed here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrianSipos @T-recks