WIP: issue with dates on write not on read (mne-tools#7135)

* issue with dates on write not on read

* add test + fixes

* fix?

* typo

Author: agramfort

mne/io/meas_info.py

@@ -582,28 +582,6 @@ def _check_consistency(self, prepend_error=''):
                 raise RuntimeError('%sinfo["meas_date"] must be a datetime '
                                    'object in UTC or None, got "%r"'
                                    % (prepend_error, repr(self['meas_date']),))
-            meas_date_stamp = _dt_to_stamp(meas_date)
-            if (meas_date_stamp[0] < np.iinfo('>i4').min or
-                    meas_date_stamp[0] > np.iinfo('>i4').max):
-                raise RuntimeError(
-                    '%sinfo["meas_date"] seconds must be between "%r" '
-                    'and "%r", got "%r"'
-                    % (prepend_error, (np.iinfo('>i4').min, 0),
-                       (np.iinfo('>i4').max, 0), meas_date_stamp[0],))
-
-        for key in ('file_id', 'meas_id'):
-            value = self.get(key)
-            if value is not None:
-                assert 'msecs' not in value
-                for key_2 in ('secs', 'usecs'):
-                    if (value[key_2] < np.iinfo('>i4').min or
-                            value[key_2] > np.iinfo('>i4').max):
-                        raise RuntimeError('%sinfo[%s][%s] must be between '
-                                           '"%r" and "%r", got "%r"'
-                                           % (prepend_error, key, key_2,
-                                              np.iinfo('>i4').min,
-                                              np.iinfo('>i4').max,
-                                              value[key_2]),)
 
         chs = [ch['ch_name'] for ch in self['chs']]
         if len(self['ch_names']) != len(chs) or any(
@@ -1290,6 +1268,40 @@ def read_meas_info(fid, tree, clean_bads=False, verbose=None):
     return info, meas
 
 
+def _check_dates(info, prepend_error=''):
+    """Check dates before writing as fif files.
+
+    It's needed because of the limited integer precision
+    of the fix standard.
+    """
+    for key in ('file_id', 'meas_id'):
+        value = info.get(key)
+        if value is not None:
+            assert 'msecs' not in value
+            for key_2 in ('secs', 'usecs'):
+                if (value[key_2] < np.iinfo('>i4').min or
+                        value[key_2] > np.iinfo('>i4').max):
+                    raise RuntimeError('%sinfo[%s][%s] must be between '
+                                       '"%r" and "%r", got "%r"'
+                                       % (prepend_error, key, key_2,
+                                          np.iinfo('>i4').min,
+                                          np.iinfo('>i4').max,
+                                          value[key_2]),)
+
+    meas_date = info.get('meas_date')
+    if meas_date is None:
+        return
+
+    meas_date_stamp = _dt_to_stamp(meas_date)
+    if (meas_date_stamp[0] < np.iinfo('>i4').min or
+            meas_date_stamp[0] > np.iinfo('>i4').max):
+        raise RuntimeError(
+            '%sinfo["meas_date"] seconds must be between "%r" '
+            'and "%r", got "%r"'
+            % (prepend_error, (np.iinfo('>i4').min, 0),
+               (np.iinfo('>i4').max, 0), meas_date_stamp[0],))
+
+
 def write_meas_info(fid, info, data_type=None, reset_range=True):
     """Write measurement info into a file id (from a fif file).
 
@@ -1311,6 +1323,7 @@ def write_meas_info(fid, info, data_type=None, reset_range=True):
     Tags are written in a particular order for compatibility with maxfilter.
     """
     info._check_consistency()
+    _check_dates(info)
 
     # Measurement info
     start_block(fid, FIFF.FIFFB_MEAS_INFO)
@@ -2082,10 +2095,13 @@ def anonymize_info(info, daysback=None, keep_his=False, verbose=None):
             if di.get(k) is not None:
                 di[k] = default_str
 
-    err_mesg = ('anonymize_info generated an inconsistent info object. Most '
-                'often this is because daysback parameter was too large. '
+    err_mesg = ('anonymize_info generated an inconsistent info object. '
                 'Underlying Error:\n')
     info._check_consistency(prepend_error=err_mesg)
+    err_mesg = ('anonymize_info generated an inconsistent info object. '
+                'daysback parameter was too large.'
+                'Underlying Error:\n')
+    _check_dates(info, prepend_error=err_mesg)
 
     return info
 

mne/io/tests/test_meas_info.py

@@ -255,6 +255,13 @@ def test_read_write_info(tmpdir):
     info2 = read_info(tmp_fname_3)
     assert info2['meas_date'] is None
 
+    # Check that having a very old date in fine until you try to save it to fif
+    info['meas_date'] = datetime(1800, 1, 1, 0, 0, 0, tzinfo=timezone.utc)
+    info._check_consistency()
+    fname = tmpdir.join('test.fif')
+    with pytest.raises(RuntimeError, match='must be between '):
+        write_info(fname, info)
+
 
 def test_io_dig_points(tmpdir):
     """Test Writing for dig files."""

setup.cfg

@@ -16,7 +16,7 @@ doc-files = doc
 
 [flake8]
 exclude = __init__.py,*externals*,constants.py,fixes.py
-ignore = W504
+ignore = W504,I100,I101,I201,N806
 
 [tool:pytest]
 addopts =