Skip to content

Commit 45ff86b

Browse files
committed
[add] Image source headers handling
1 parent e8098fd commit 45ff86b

File tree

5 files changed

+163
-23
lines changed

5 files changed

+163
-23
lines changed

packages/react-native-web-examples/pages/image/index.js

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,18 @@ const dataBase64Svg =
1515
'data:image/svg+xml;base64,PHN2ZyB3aWR0aD0nMjAwJyBoZWlnaHQ9JzIwMCcgZmlsbD0iIzAwMDAwMCIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayIgdmVyc2lvbj0iMS4xIiB4PSIwcHgiIHk9IjBweCIgdmlld0JveD0iMCAwIDEwMCAxMDAiIGVuYWJsZS1iYWNrZ3JvdW5kPSJuZXcgMCAwIDEwMCAxMDAiIHhtbDpzcGFjZT0icHJlc2VydmUiPjxnPjxwYXRoIGQ9Ik0yNS44NjcsNDguODUzQzMyLjgwNiw1MC4xNzYsNDYuNDYsNTIuNSw2MS4yMTUsNTIuNWgwLjAwNWM5LjcxLDAsMTguNDAxLTEuMDU3LDI1LjkzOC0yLjkxMyAgIGMwLjE1OS0wLjA0NiwwLjM1LTAuMTM1LDAuNTY1LTAuMTg3YzAuMjgyLTAuMDcyLDAuNTY1LTAuMTY0LDAuODQ0LTAuMjM4YzMuMTg0LTAuOTY0LDIuNTc3LTMuMDUxLDIuMTk5LTMuODUyICAgYy00LjE2Ni03LjcxOS0xNS4wODYtMjMuNDE1LTM1LjAyOC0yMy40MTVjLTIyLjE2OSwwLTMwLjI2MiwxMC42MzUtMzMuMTQsMTkuNTg5QzIyLjU0NSw0Mi4zMzMsMjIuNDA3LDQ3LjEzNSwyNS44NjcsNDguODUzeiAgICBNMjguNjc2LDM4LjAzMmMwLjAxMy0wLjAzNiwwLjYxNC0xLjYyNiwxLjkyMy0xLjAwOGMxLjEzMywwLjUzNSwwLjk2MSwxLjU2MywwLjg4NywxLjg1Yy0wLjAwNywwLjAyNC0wLjAxNCwwLjA0OC0wLjAyMSwwLjA3MyAgIGMwLDAuMDAxLTAuMDAxLDAuMDA0LTAuMDAxLDAuMDA0bDAsMGMtMC4yNDksMC45MjktMC40MDQsMi4wODYtMC4wMTcsMi44NmMwLjE2LDAuMzE5LDAuNDkyLDAuNzY4LDEuNTQyLDAuOTg3bDAuMzY2LDAuMDc3ICAgYzIwLjgxNiw0LjM2LDM2LDIuOTMzLDQ1LjY3OCwwLjYyNmwtMC4wMDQsMC4wMDJjMCwwLDAuMDA1LTAuMDAyLDAuMDA3LTAuMDAzYzAuMjEyLTAuMDUsMC40MjEtMC4xMDEsMC42MjgtMC4xNTIgICBjMC41MDktMC4wNSwxLjE3MywwLjA3OCwxLjM5OSwxYzAuMzUxLDEuNDI0LTAuOTczLDEuODk1LTEuMjE3LDEuOTY5Yy01LjMyNSwxLjI3OS0xMi4yNjYsMi4zMDYtMjAuODM1LDIuMzA3ICAgYy03LjUwNSwwLTE2LjI1NS0wLjc4Ny0yNi4yNTctMi44ODJsLTAuMzY0LTAuMDc3Yy0yLjEyLTAuNDQyLTMuMTExLTEuNjMzLTMuNTY5LTIuNTU1QzI3Ljk4NSw0MS40MjEsMjguMjgxLDM5LjQxNiwyOC42NzYsMzguMDMyICAgeiI+PC9wYXRoPjxjaXJjbGUgY3g9IjEwLjQ5MyIgY3k9IjIzLjQ1NSIgcj0iMC42MTkiPjwvY2lyY2xlPjxwYXRoIGQ9Ik0yLjA4LDI4LjMwOGMwLjY3Ni0wLjE3OCwwLjk4My0wLjM1MiwxLjE3NC0wLjVDNC42OSwyNi42OSw2LjUsMjcuNDgzLDcuNSwyOC4zNTd2MC4wMDJjMCwwLDEuNzExLDEuMjM1LDAuNzM3LDIuMjAyICAgYy0wLjk3NCwwLjk2NS0yLjMxOSwwLjAwNi0yLjMxOSwwLjAwNmwwLjAzNSwwLjAxNmMtMC4zMjctMC4yMDMtMC42LTAuNTYxLTAuNzgtMC41ODRjLTAuMzcsMC4yNi0wLjg3NiwwLjUtMS40NzYsMC41SDMuNyAgIGMwLDAtMS4zNDUsMC43MDksMC4xNzgsMS42NTJjMC4wMDEsMC4wMDEsMC4wMDIsMC4wNzIsMC4wMDQsMC4wNzNjMy45MzksMi4zNDIsOC4yNzEsNS43MDEsOC4yNzEsOC44OCAgIGMwLDAuNjkxLDAuMiwxNy4wNDIsMTcuNjI2LDI0LjczOWwwLjk2NywwLjQ0MmwtMC4xLDEuMDU5Yy0wLjQyMSw0LjM5LDEuMTQ1LDEwLjE5MSwxMC45OTMsMTIuODg4bDAuMTEzLDAuMDM4ICAgYzAuMDY3LDAuMDIzLDYuNzMyLDIuNDI5LDEwLjkwNywyLjQyOWMxLjU4NCwwLDIuMTU1LTAuMzUyLDIuMjQzLTAuNTYxYzAuMDg1LTAuMjAyLDAuNjEyLTIuMTY0LTYuMzMyLTkuMzg3bDAuMDAyLTAuMTgzICAgYzAsMC0yLjQ3Ny0zLjA3LDEuNTMzLTMuMDdjMC4wMSwwLDAuMDE5LDAsMC4wMjksMGMxLjI4NSwwLDIuNjA4LDAuMjE1LDMuOTgsMC4xODRjNC43NzEtMC4xMTcsOS4zMTYtMC40MjUsMTMuNTA2LTEuMDk2ICAgbDAuNDc0LTAuMDI4bDAuNjY4LDAuMTU4YzkuNjUxLDQuOTQ4LDE2LjczOCw3LjcxNiwxOS43MzgsNy43MTZ2MC4wMDZjMCwwLDAuMTY0LDAuMDExLDAuMjMsMC4wMDQgICBjLTAuMTg5LTAuNzIzLTIuMjMtMi44LTcuMjMtOS4wNzl2MC4wMjFjMCwwLTEuNTEyLTEuNjU4LDAuNzk3LTIuNjUzYzAuMDYzLTAuMDI2LDAuMDA4LDAuMDIzLDAuMDYtMC4wMDEgICBjOC42MzktMy41MDksMTMuNTAxLTguMjA0LDE1LjQxMS0xMS43NzVjMS4xNDUtMi4xMjksMC4yMDYtMi43ODQtMC42NTktMi45NzZjLTAuMzE3LTAuMDM4LTAuNjM0LTAuMDYyLTAuOTEyLTAuMDYyICAgYy0wLjIwNSwwLTAuMzc5LDAuMDEtMC41MjgsMC4wMjdsLTMuMTQzLDEuMjE0QzgzLjczMiw1My45MjYsNzMuMjE4LDU1LjUsNjEuMjIsNTUuNWMtMC4wMDIsMC0wLjAwNSwwLTAuMDA1LDAgICBjLTE1LjEyOCwwLTI5LjEwMS0yLjQzMi0zNi4wODMtMy43NzFsLTAuMTczLTAuMTExbC0wLjE2LTAuMTI2Yy01Ljg1OC0yLjY4MS01LjEzNy0xMC4yMDItNS4xMDMtMTAuNTE5bDAuMDYtMC4zICAgYzAuODk1LTIuODM4LDIuNDY3LTYuMzUyLDUuMjEzLTkuNzE5Yy0xLjgwOC0xLjM2OS00LjU5LTQuMTg4LTQuNDMtOC40OTRjMC4wNDYtMS4yNDQtMC40ODYtMi41MDgtMS40OTgtMy41NTkgICBjLTEuNDk4LTEuNTU1LTMuNzg1LTIuNDQ2LTYuMjc0LTIuNDQ2Yy0xLjc3LDAtMy41NTMsMC40NDItNS4yOTMsMS4zMTRjLTQuMDYxLDIuMDM1LTQuODU1LDQuNzM2LTUuNjkyLDcuNTk2ICAgYy0wLjEzNiwwLjQ2OC0wLjI4NCwwLjkzOS0wLjQzOCwxLjQxYy0wLjAwNiwwLjAxOS0wLjAyMiwwLjAzNS0wLjAyOCwwLjA1NkMwLjgzMywyOC40MjMsMS42OTEsMjguMzksMi4wOCwyOC4zMDh6IE0xMC40OTMsMTkuOTA4ICAgYzEuOTU2LDAsMy41NDgsMS41OTEsMy41NDgsMy41NDdjMCwxLjk1Ny0xLjU5MiwzLjU0OC0zLjU0OCwzLjU0OGMtMS45NTcsMC0zLjU0OC0xLjU5Mi0zLjU0OC0zLjU0OCAgIEM2Ljk0NCwyMS40OTksOC41MzYsMTkuOTA4LDEwLjQ5MywxOS45MDh6Ij48L3BhdGg+PC9nPjwvc3ZnPg==';
1616
const dataSvg =
1717
'data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 841.9 595.3"><g fill="#61DAFB"><path d="M666.3 296.5c0-32.5-40.7-63.3-103.1-82.4 14.4-63.6 8-114.2-20.2-130.4-6.5-3.8-14.1-5.6-22.4-5.6v22.3c4.6 0 8.3.9 11.4 2.6 13.6 7.8 19.5 37.5 14.9 75.7-1.1 9.4-2.9 19.3-5.1 29.4-19.6-4.8-41-8.5-63.5-10.9-13.5-18.5-27.5-35.3-41.6-50 32.6-30.3 63.2-46.9 84-46.9V78c-27.5 0-63.5 19.6-99.9 53.6-36.4-33.8-72.4-53.2-99.9-53.2v22.3c20.7 0 51.4 16.5 84 46.6-14 14.7-28 31.4-41.3 49.9-22.6 2.4-44 6.1-63.6 11-2.3-10-4-19.7-5.2-29-4.7-38.2 1.1-67.9 14.6-75.8 3-1.8 6.9-2.6 11.5-2.6V78.5c-8.4 0-16 1.8-22.6 5.6-28.1 16.2-34.4 66.7-19.9 130.1-62.2 19.2-102.7 49.9-102.7 82.3 0 32.5 40.7 63.3 103.1 82.4-14.4 63.6-8 114.2 20.2 130.4 6.5 3.8 14.1 5.6 22.5 5.6 27.5 0 63.5-19.6 99.9-53.6 36.4 33.8 72.4 53.2 99.9 53.2 8.4 0 16-1.8 22.6-5.6 28.1-16.2 34.4-66.7 19.9-130.1 62-19.1 102.5-49.9 102.5-82.3zm-130.2-66.7c-3.7 12.9-8.3 26.2-13.5 39.5-4.1-8-8.4-16-13.1-24-4.6-8-9.5-15.8-14.4-23.4 14.2 2.1 27.9 4.7 41 7.9zm-45.8 106.5c-7.8 13.5-15.8 26.3-24.1 38.2-14.9 1.3-30 2-45.2 2-15.1 0-30.2-.7-45-1.9-8.3-11.9-16.4-24.6-24.2-38-7.6-13.1-14.5-26.4-20.8-39.8 6.2-13.4 13.2-26.8 20.7-39.9 7.8-13.5 15.8-26.3 24.1-38.2 14.9-1.3 30-2 45.2-2 15.1 0 30.2.7 45 1.9 8.3 11.9 16.4 24.6 24.2 38 7.6 13.1 14.5 26.4 20.8 39.8-6.3 13.4-13.2 26.8-20.7 39.9zm32.3-13c5.4 13.4 10 26.8 13.8 39.8-13.1 3.2-26.9 5.9-41.2 8 4.9-7.7 9.8-15.6 14.4-23.7 4.6-8 8.9-16.1 13-24.1zM421.2 430c-9.3-9.6-18.6-20.3-27.8-32 9 .4 18.2.7 27.5.7 9.4 0 18.7-.2 27.8-.7-9 11.7-18.3 22.4-27.5 32zm-74.4-58.9c-14.2-2.1-27.9-4.7-41-7.9 3.7-12.9 8.3-26.2 13.5-39.5 4.1 8 8.4 16 13.1 24 4.7 8 9.5 15.8 14.4 23.4zM420.7 163c9.3 9.6 18.6 20.3 27.8 32-9-.4-18.2-.7-27.5-.7-9.4 0-18.7.2-27.8.7 9-11.7 18.3-22.4 27.5-32zm-74 58.9c-4.9 7.7-9.8 15.6-14.4 23.7-4.6 8-8.9 16-13 24-5.4-13.4-10-26.8-13.8-39.8 13.1-3.1 26.9-5.8 41.2-7.9zm-90.5 125.2c-35.4-15.1-58.3-34.9-58.3-50.6 0-15.7 22.9-35.6 58.3-50.6 8.6-3.7 18-7 27.7-10.1 5.7 19.6 13.2 40 22.5 60.9-9.2 20.8-16.6 41.1-22.2 60.6-9.9-3.1-19.3-6.5-28-10.2zM310 490c-13.6-7.8-19.5-37.5-14.9-75.7 1.1-9.4 2.9-19.3 5.1-29.4 19.6 4.8 41 8.5 63.5 10.9 13.5 18.5 27.5 35.3 41.6 50-32.6 30.3-63.2 46.9-84 46.9-4.5-.1-8.3-1-11.3-2.7zm237.2-76.2c4.7 38.2-1.1 67.9-14.6 75.8-3 1.8-6.9 2.6-11.5 2.6-20.7 0-51.4-16.5-84-46.6 14-14.7 28-31.4 41.3-49.9 22.6-2.4 44-6.1 63.6-11 2.3 10.1 4.1 19.8 5.2 29.1zm38.5-66.7c-8.6 3.7-18 7-27.7 10.1-5.7-19.6-13.2-40-22.5-60.9 9.2-20.8 16.6-41.1 22.2-60.6 9.9 3.1 19.3 6.5 28.1 10.2 35.4 15.1 58.3 34.9 58.3 50.6-.1 15.7-23 35.6-58.4 50.6zM320.8 78.4z"/><circle cx="420.9" cy="296.5" r="45.7"/><path d="M520.5 78.1z"/></g></svg>';
18+
const sourceWithHeaders = {
19+
uri: placeholder,
20+
headers: {
21+
'x-token': '0012345'
22+
}
23+
};
24+
const sourceWithHeadersAndRedirect = {
25+
uri: source,
26+
headers: {
27+
'x-token': '0012345'
28+
}
29+
};
1830

1931
function Divider() {
2032
return <View style={styles.divider} />;
@@ -114,6 +126,17 @@ export default function ImagePage() {
114126
/>
115127
</View>
116128
</View>
129+
<Divider />
130+
<View style={styles.row}>
131+
<View style={styles.column}>
132+
<Text style={[styles.text]}>With Headers</Text>
133+
<Image source={sourceWithHeaders} style={styles.image} />
134+
</View>
135+
<View style={styles.column}>
136+
<Text style={[styles.text]}>Headers & Redirect</Text>
137+
<Image source={sourceWithHeadersAndRedirect} style={styles.image} />
138+
</View>
139+
</View>
117140
</Example>
118141
);
119142
}

packages/react-native-web/src/exports/Image/index.js

Lines changed: 91 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
* @flow
99
*/
1010

11+
import type { ImageSource, LoadRequest } from '../../modules/ImageLoader';
1112
import type { ImageProps } from './types';
1213

1314
import * as React from 'react';
@@ -151,6 +152,23 @@ function resolveAssetUri(source): ?string {
151152
return uri;
152153
}
153154

155+
function raiseOnErrorEvent(uri, { onError, onLoadEnd }) {
156+
if (onError) {
157+
onError({
158+
nativeEvent: {
159+
error: `Failed to load resource ${uri} (404)`
160+
}
161+
});
162+
}
163+
if (onLoadEnd) onLoadEnd();
164+
}
165+
166+
function hasSourceDiff(a: ImageSource, b: ImageSource) {
167+
return (
168+
a.uri !== b.uri || JSON.stringify(a.headers) !== JSON.stringify(b.headers)
169+
);
170+
}
171+
154172
interface ImageStatics {
155173
getSize: (
156174
uri: string,
@@ -163,10 +181,12 @@ interface ImageStatics {
163181
) => Promise<{| [uri: string]: 'disk/memory' |}>;
164182
}
165183

166-
const Image: React.AbstractComponent<
184+
type ImageComponent = React.AbstractComponent<
167185
ImageProps,
168186
React.ElementRef<typeof View>
169-
> = React.forwardRef((props, ref) => {
187+
>;
188+
189+
const BaseImage: ImageComponent = React.forwardRef((props, ref) => {
170190
const {
171191
accessibilityLabel,
172192
blurRadius,
@@ -284,16 +304,7 @@ const Image: React.AbstractComponent<
284304
},
285305
function error() {
286306
updateState(ERRORED);
287-
if (onError) {
288-
onError({
289-
nativeEvent: {
290-
error: `Failed to load resource ${uri} (404)`
291-
}
292-
});
293-
}
294-
if (onLoadEnd) {
295-
onLoadEnd();
296-
}
307+
raiseOnErrorEvent(uri, { onError, onLoadEnd });
297308
}
298309
);
299310
}
@@ -337,14 +348,76 @@ const Image: React.AbstractComponent<
337348
);
338349
});
339350

340-
Image.displayName = 'Image';
351+
BaseImage.displayName = 'Image';
352+
353+
/**
354+
* This component handles specifically loading an image source with headers
355+
* default source is never loaded using headers
356+
*/
357+
const ImageWithHeaders: ImageComponent = React.forwardRef((props, ref) => {
358+
// $FlowIgnore: This component would only be rendered when `source` matches `ImageSource`
359+
const nextSource: ImageSource = props.source;
360+
const [blobUri, setBlobUri] = React.useState('');
361+
const request = React.useRef<LoadRequest>({
362+
cancel: () => {},
363+
source: { uri: '', headers: {} },
364+
promise: Promise.resolve('')
365+
});
366+
367+
const { onError, onLoadStart, onLoadEnd } = props;
368+
369+
React.useEffect(() => {
370+
if (!hasSourceDiff(nextSource, request.current.source)) {
371+
return;
372+
}
373+
374+
// When source changes we want to clean up any old/running requests
375+
request.current.cancel();
376+
377+
if (onLoadStart) {
378+
onLoadStart();
379+
}
380+
381+
// Store a ref for the current load request so we know what's the last loaded source,
382+
// and so we can cancel it if a different source is passed through props
383+
request.current = ImageLoader.loadWithHeaders(nextSource);
384+
385+
request.current.promise
386+
.then((uri) => setBlobUri(uri))
387+
.catch(() =>
388+
raiseOnErrorEvent(request.current.source.uri, { onError, onLoadEnd })
389+
);
390+
}, [nextSource, onLoadStart, onError, onLoadEnd]);
391+
392+
// Cancel any request on unmount
393+
React.useEffect(() => request.current.cancel, []);
394+
395+
const propsToPass = {
396+
...props,
397+
398+
// `onLoadStart` is called from the current component
399+
// We skip passing it down to prevent BaseImage raising it a 2nd time
400+
onLoadStart: undefined,
401+
402+
// Until the current component resolves the request (using headers)
403+
// we skip forwarding the source so the base component doesn't attempt
404+
// to load the original source
405+
source: blobUri ? { ...nextSource, uri: blobUri } : undefined
406+
};
407+
408+
return <BaseImage ref={ref} {...propsToPass} />;
409+
});
341410

342411
// $FlowIgnore: This is the correct type, but casting makes it unhappy since the variables aren't defined yet
343-
const ImageWithStatics = (Image: React.AbstractComponent<
344-
ImageProps,
345-
React.ElementRef<typeof View>
346-
> &
347-
ImageStatics);
412+
const ImageWithStatics: ImageComponent & ImageStatics = React.forwardRef(
413+
(props, ref) => {
414+
if (props.source && props.source.headers) {
415+
return <ImageWithHeaders ref={ref} {...props} />;
416+
}
417+
418+
return <BaseImage ref={ref} {...props} />;
419+
}
420+
);
348421

349422
ImageWithStatics.getSize = function (uri, success, failure) {
350423
ImageLoader.getSize(uri, success, failure);

packages/react-native-web/src/exports/Image/types.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ export type ImageStyle = {
102102
tintColor?: ColorValue
103103
};
104104

105-
export type ImageProps = {
106-
...ViewProps,
105+
export type ImageProps = {|
106+
...$Exact<ViewProps>,
107107
blurRadius?: number,
108108
defaultSource?: Source,
109109
draggable?: boolean,
@@ -116,4 +116,4 @@ export type ImageProps = {
116116
resizeMode?: ResizeMode,
117117
source?: Source,
118118
style?: GenericStyleProp<ImageStyle>
119-
};
119+
|};

packages/react-native-web/src/exports/ImageBackground/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ import Image from '../Image';
1616
import StyleSheet from '../StyleSheet';
1717
import View from '../View';
1818

19-
type ImageBackgroundProps = {
19+
type ImageBackgroundProps = {|
2020
...ImageProps,
2121
imageRef?: any,
2222
imageStyle?: $PropertyType<ImageProps, 'style'>,
2323
style?: $PropertyType<ViewProps, 'style'>
24-
};
24+
|};
2525

2626
const emptyObject = {};
2727

packages/react-native-web/src/modules/ImageLoader/index.js

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,41 @@ const ImageLoader = {
136136
};
137137
image.src = uri;
138138
requests[`${id}`] = image;
139+
139140
return id;
140141
},
142+
loadWithHeaders(source: ImageSource): LoadRequest {
143+
let uri: string;
144+
const abortController = new AbortController();
145+
const request = new Request(source.uri, {
146+
headers: source.headers,
147+
signal: abortController.signal
148+
});
149+
request.headers.append('accept', 'image/*');
150+
151+
const promise = fetch(request)
152+
.then((response) => response.blob())
153+
.then((blob) => {
154+
uri = URL.createObjectURL(blob);
155+
return uri;
156+
})
157+
.catch((error) => {
158+
if (error.name === 'AbortError') {
159+
return '';
160+
}
161+
162+
throw error;
163+
});
164+
165+
return {
166+
promise,
167+
source,
168+
cancel: () => {
169+
abortController.abort();
170+
URL.revokeObjectURL(uri);
171+
}
172+
};
173+
},
141174
prefetch(uri: string): Promise<void> {
142175
return new Promise((resolve, reject) => {
143176
ImageLoader.load(
@@ -164,4 +197,15 @@ const ImageLoader = {
164197
}
165198
};
166199

200+
export type LoadRequest = {|
201+
cancel: Function,
202+
source: ImageSource,
203+
promise: Promise<string>
204+
|};
205+
206+
export type ImageSource = {
207+
uri: string,
208+
headers: { [key: string]: string }
209+
};
210+
167211
export default ImageLoader;

0 commit comments

Comments
 (0)