Skip to content

Commit 1a88ce2

Browse files
committed
refactor(common): Switch TypeScript module to node16
Switch Node.js compiler option `module` from `commonjs` to `node16`, to preserve dynamic import. With `commonjs` these are converted to `require`. This allows to deprecate the `load-esm` dependency, introduced in 1e43fcb.
1 parent 86eb46d commit 1a88ce2

File tree

11 files changed

+11
-33
lines changed

11 files changed

+11
-33
lines changed

integration/auto-mock/test/bar.service.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Test } from '@nestjs/testing';
22
import * as chai from 'chai';
3-
import * as chaiAsPromised from 'chai-as-promised';
3+
import chaiAsPromised from 'chai-as-promised';
44
import * as sinon from 'sinon';
55
import { BarService } from '../src/bar.service';
66
import { FooService } from '../src/foo.service';

integration/injector/e2e/injector.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { UnknownExportException } from '@nestjs/core/errors/exceptions/unknown-e
44
import { Test } from '@nestjs/testing';
55
import { expect } from 'chai';
66
import * as chai from 'chai';
7-
import * as chaiAsPromised from 'chai-as-promised';
7+
import chaiAsPromised from 'chai-as-promised';
88
import {
99
DYNAMIC_TOKEN,
1010
DYNAMIC_VALUE,

integration/microservices/e2e/math-grpc.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { MicroserviceOptions, Transport } from '@nestjs/microservices';
55
import { Test } from '@nestjs/testing';
66
import { fail } from 'assert';
77
import { expect, use } from 'chai';
8-
import * as chaiAsPromised from 'chai-as-promised';
8+
import chaiAsPromised from 'chai-as-promised';
99
import { join } from 'path';
1010
import * as sinon from 'sinon';
1111
import * as request from 'supertest';

package-lock.json

-20
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969
"fast-safe-stringify": "2.1.1",
7070
"file-type": "20.4.1",
7171
"iterare": "1.2.1",
72-
"load-esm": "1.0.2",
7372
"object-hash": "3.0.0",
7473
"path-to-regexp": "8.2.0",
7574
"reflect-metadata": "0.2.2",
@@ -247,5 +246,6 @@
247246
"hooks/mocha-init-hook.ts"
248247
],
249248
"exit": true
250-
}
249+
},
250+
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
251251
}

packages/common/pipes/file/file-type.validator.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { FileValidator } from './file-validator.interface';
22
import { IFile } from './interfaces';
3-
import { loadEsm } from 'load-esm';
43

54
export type FileTypeValidatorOptions = {
65
fileType: string | RegExp;
@@ -51,8 +50,7 @@ export class FileTypeValidator extends FileValidator<
5150
}
5251

5352
try {
54-
const { fileTypeFromBuffer } =
55-
await loadEsm<typeof import('file-type')>('file-type');
53+
const { fileTypeFromBuffer } = await import('file-type');
5654

5755
const fileType = await fileTypeFromBuffer(file.buffer);
5856

packages/common/test/pipes/parse-array.pipe.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as chai from 'chai';
22
import { expect } from 'chai';
3-
import * as chaiAsPromised from 'chai-as-promised';
3+
import chaiAsPromised from 'chai-as-promised';
44
import { Type } from 'class-transformer';
55
import {
66
IsBoolean,

packages/common/test/pipes/validation.pipe.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as chai from 'chai';
22
import { expect } from 'chai';
3-
import * as chaiAsPromised from 'chai-as-promised';
3+
import chaiAsPromised from 'chai-as-promised';
44
import { Exclude, Expose, Type } from 'class-transformer';
55
import {
66
IsArray,

packages/core/test/injector/injector.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Optional } from '@nestjs/common';
22
import { PARAMTYPES_METADATA } from '@nestjs/common/constants';
33
import * as chai from 'chai';
44
import { expect } from 'chai';
5-
import * as chaiAsPromised from 'chai-as-promised';
5+
import chaiAsPromised from 'chai-as-promised';
66
import * as sinon from 'sinon';
77
import { Inject } from '../../../common/decorators/core/inject.decorator';
88
import { Injectable } from '../../../common/decorators/core/injectable.decorator';

packages/core/test/middleware/middleware-module.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Injectable } from '@nestjs/common';
22
import { RouteInfoPathExtractor } from '@nestjs/core/middleware/route-info-path-extractor';
33
import * as chai from 'chai';
44
import { expect } from 'chai';
5-
import * as chaiAsPromised from 'chai-as-promised';
5+
import chaiAsPromised from 'chai-as-promised';
66
import * as sinon from 'sinon';
77
import { Controller } from '../../../common/decorators/core/controller.decorator';
88
import { RequestMapping } from '../../../common/decorators/http/request-mapping.decorator';

tsconfig.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"compilerOptions": {
3-
"module": "commonjs",
3+
"module": "node16",
44
"noImplicitAny": false,
55
"noUnusedLocals": false,
66
"removeComments": true,

0 commit comments

Comments
 (0)