Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add is_full_depth to devices #2797

Open
phillf opened this issue Feb 16, 2025 · 4 comments
Open

Enhancement: Add is_full_depth to devices #2797

phillf opened this issue Feb 16, 2025 · 4 comments
Assignees

Comments

@phillf
Copy link
Contributor

phillf commented Feb 16, 2025

Hi @phillf
Just had a look and about 118 are missing the is_full_depth property.

Originally posted by @harryajc in #2708

Please assign me as owner.

Tag with:
status: Needs PR
type: enhancement

I think adding an enhancement tag is appropriate here. This isn't a bug per se. I see this more as a schema data quality improvement.

@danner26
Copy link
Member

Completed. Please feel free to submit a PR and reference this issue. Thanks!

@harryajc
Copy link
Collaborator

Hi,
Was thinking about another missing mandatory field. The position field in module-bays should be required as it causes issues if the module trying to be added to the bay has used the {module} variable. Although I recon add this might also require some updating of devices that have already been added

@phillf
Copy link
Contributor Author

phillf commented Feb 17, 2025

@harryajc @danner26, are there other fields that you can think of that would make sense to require?

@harryajc
Copy link
Collaborator

@harryajc @danner26, are there other fields that you can think of that would make sense to require?

Not that I can think of right now. I am planning to put together a PR for the module-bays position requirement but have to fix around 150 devices first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants