Skip to content

Commit 7bcbe12

Browse files
authored
Remove duplicate kind cluster creation (#257)
Kind clusters for the e2e tests are implicitly created in the make test-e2e-* targets that are triggered in the Run e2e tests steps of the e2e-tests pipeline. Thus, there is no need for the additional Start kind cluster step in the e2e tests pipeline. This PR removes the additional kind cluster creation.
1 parent e099af3 commit 7bcbe12

File tree

1 file changed

+0
-54
lines changed

1 file changed

+0
-54
lines changed

.github/workflows/e2e-tests.yaml

-54
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,6 @@ jobs:
2525
- name: Import environment variables from file
2626
run: |
2727
cat ".github/env" >> "$GITHUB_ENV"
28-
- name: Start kind cluster
29-
uses: helm/kind-action@a1b0e391336a6ee6713a0583f8c6240d70863de3 # v1.12.0
30-
with:
31-
version: ${{ env.kind-version }}
32-
node_image: ${{ env.kind-image }}
33-
wait: 300s
34-
config: ./tests/e2e/kind-config.yaml
35-
cluster_name: e2e
36-
- name: Wait for cluster to finish bootstraping
37-
run: |
38-
echo "Waiting for all nodes to be ready..."
39-
kubectl wait --for=condition=Ready nodes --all --timeout=120s
40-
kubectl get nodes
41-
echo "Waiting for all pods to be ready..."
42-
kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout=300s
43-
kubectl get pods -A
44-
echo "Cluster information"
45-
kubectl cluster-info
4628
- name: Run e2e tests
4729
run: |
4830
make test-e2e-3.7.8
@@ -57,24 +39,6 @@ jobs:
5739
- name: Import environment variables from file
5840
run: |
5941
cat ".github/env" >> "$GITHUB_ENV"
60-
- name: Start kind cluster
61-
uses: helm/kind-action@a1b0e391336a6ee6713a0583f8c6240d70863de3 # v1.12.0
62-
with:
63-
version: ${{ env.kind-version }}
64-
node_image: ${{ env.kind-image }}
65-
wait: 300s
66-
config: ./tests/e2e/kind-config.yaml
67-
cluster_name: e2e
68-
- name: Wait for cluster to finish bootstraping
69-
run: |
70-
echo "Waiting for all nodes to be ready..."
71-
kubectl wait --for=condition=Ready nodes --all --timeout=120s
72-
kubectl get nodes
73-
echo "Waiting for all pods to be ready..."
74-
kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout=300s
75-
kubectl get pods -A
76-
echo "Cluster information"
77-
kubectl cluster-info
7842
- name: Run e2e tests
7943
run: |
8044
make test-e2e-4.0.11
@@ -89,24 +53,6 @@ jobs:
8953
- name: Import environment variables from file
9054
run: |
9155
cat ".github/env" >> "$GITHUB_ENV"
92-
- name: Start kind cluster
93-
uses: helm/kind-action@a1b0e391336a6ee6713a0583f8c6240d70863de3 # v1.12.0
94-
with:
95-
version: ${{ env.kind-version }}
96-
node_image: ${{ env.kind-image }}
97-
wait: 300s
98-
config: ./tests/e2e/kind-config.yaml
99-
cluster_name: e2e
100-
- name: Wait for cluster to finish bootstraping
101-
run: |
102-
echo "Waiting for all nodes to be ready..."
103-
kubectl wait --for=condition=Ready nodes --all --timeout=120s
104-
kubectl get nodes
105-
echo "Waiting for all pods to be ready..."
106-
kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout=300s
107-
kubectl get pods -A
108-
echo "Cluster information"
109-
kubectl cluster-info
11056
- name: Run e2e tests
11157
run: |
11258
make test-e2e-4.1.8

0 commit comments

Comments
 (0)