Skip to content

Commit b839675

Browse files
shaneuttvMaroon
authored andcommitted
chore: add defaults for images in kubernetes dev env
Signed-off-by: Shane Utt <shaneutt@linux.com>
1 parent 06cc8b3 commit b839675

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

Makefile

+4-12
Original file line numberDiff line numberDiff line change
@@ -754,6 +754,10 @@ endif
754754
# This target deploys the GIE stack in a specific namespace for development and
755755
# testing.
756756
# ------------------------------------------------------------------------------
757+
VLLM_SIM_IMAGE ?= quay.io/vllm-d/vllm-sim
758+
VLLM_SIM_TAG ?= 0.0.2
759+
EPP_IMAGE ?= us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp
760+
EPP_TAG ?= main
757761
.PHONY: environment.dev.kubernetes
758762
environment.dev.kubernetes: check-kubectl check-kustomize check-envsubst
759763
@echo "INFO: checking required vars"
@@ -765,21 +769,9 @@ ifndef REGISTRY_SECRET
765769
$(error "Error: REGISTRY_SECRET is required but not set)
766770
endif
767771
export REGISTRY_SECRET=${REGISTRY_SECRET}
768-
ifndef VLLM_SIM_IMAGE
769-
$(error "Error: VLLM_SIM_IMAGE is required but not set)
770-
endif
771772
export VLLM_SIM_IMAGE=${VLLM_SIM_IMAGE}
772-
ifndef VLLM_SIM_TAG
773-
$(error "Error: VLLM_SIM_TAG is required but not set)
774-
endif
775773
export VLLM_SIM_TAG=${VLLM_SIM_TAG}
776-
ifndef EPP_IMAGE
777-
$(error "Error: EPP_IMAGE is required but not set)
778-
endif
779774
export EPP_IMAGE=${EPP_IMAGE}
780-
ifndef EPP_TAG
781-
$(error "Error: EPP_TAG is required but not set)
782-
endif
783775
export EPP_TAG=${EPP_TAG}
784776
@echo "INFO: Creating namespace (if needed) and setting context to $(NAMESPACE)..."
785777
kubectl create namespace $(NAMESPACE) 2>/dev/null || true

0 commit comments

Comments
 (0)