Fix the checkAttributeReportTriggersConfigurationChanged API and invert the expectation for device configuration changed when expectConfigurationChanged is set to NO

Author: nivi-apple

src/darwin/Framework/CHIPTests/MTRDeviceTests.m

@@ -3082,6 +3082,7 @@ + (void)checkAttributeReportTriggersConfigurationChanged:(MTRAttributeIDType)att
     XCTestExpectation * gotAttributeReportExpectation = [testcase expectationWithDescription:@"Attribute report has been received"];
     XCTestExpectation * gotAttributeReportEndExpectation = [testcase expectationWithDescription:@"Attribute report has ended"];
     XCTestExpectation * deviceConfigurationChangedExpectation = [testcase expectationWithDescription:@"Device configuration changed was receieved"];
+    deviceConfigurationChangedExpectation.inverted = !expectConfigurationChanged;
 
     __block unsigned attributeReportsReceived = 0;
     __block NSArray<NSDictionary<NSString *, id> *> * testDataValue = nil;
@@ -3125,19 +3126,15 @@ + (void)checkAttributeReportTriggersConfigurationChanged:(MTRAttributeIDType)att
     __block BOOL wasOnDeviceConfigurationChangedCallbackCalled = NO;
 
     delegate.onDeviceConfigurationChanged = ^() {
-        if (expectConfigurationChanged) {
             [deviceConfigurationChangedExpectation fulfill];
-        }
         wasOnDeviceConfigurationChangedCallbackCalled = YES;
     };
 
     [device unitTestInjectAttributeReport:attributeReport];
 
-    if (expectConfigurationChanged) {
-        [testcase waitForExpectations:@[ gotAttributeReportExpectation, gotAttributeReportEndExpectation, deviceConfigurationChangedExpectation ] timeout:kTimeoutInSeconds];
-        XCTAssertTrue(wasOnDeviceConfigurationChangedCallbackCalled);
-    } else {
-        [testcase waitForExpectations:@[ gotAttributeReportExpectation, gotAttributeReportEndExpectation ] timeout:kTimeoutInSeconds];
+    [testcase waitForExpectations:@[ gotAttributeReportExpectation, gotAttributeReportEndExpectation, deviceConfigurationChangedExpectation ] timeout:kTimeoutInSeconds];
+    if (!expectConfigurationChanged)
+    {
         XCTAssertFalse(wasOnDeviceConfigurationChangedCallbackCalled);
     }
 }