Skip to content

Commit 6376082

Browse files
committed
Make fixes to match the test scripts to the test plan
- Set the PICS code for SetpointHoldExpiryTimestamp to 0 - Remove the test cases for GetRelayLog and GetRelayLogResponse - Update PICS code for Preset related commands
1 parent 52baf83 commit 6376082

File tree

3 files changed

+13
-27
lines changed

3 files changed

+13
-27
lines changed

src/app/tests/suites/certification/PICS.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -6494,6 +6494,12 @@ PICS:
64946494
- label: "Does the device implement the Schedules attribute?"
64956495
id: TSTAT.S.A0051
64966496

6497+
- label: "Does the device implement the Schedules attribute?"
6498+
id: TSTAT.S.A0051
6499+
6500+
- label: "Does the device implement the SetpointHoldExpiryTimestamp attribute?"
6501+
id: TSTAT.S.A0052
6502+
64976503
#
64986504
# server / commandsReceived
64996505
#

src/app/tests/suites/certification/Test_TC_TSTAT_1_1.yaml

+6-27
Original file line numberDiff line numberDiff line change
@@ -606,17 +606,7 @@ tests:
606606
contains: [1, 2, 3]
607607

608608
- label:
609-
"Step 6c: TH reads the optional (GetRelayStatusLog) command in
610-
AcceptedCommandList"
611-
PICS: TSTAT.S.C04.Rsp
612-
command: "readAttribute"
613-
attribute: "AcceptedCommandList"
614-
response:
615-
constraints:
616-
type: list
617-
contains: [4]
618-
- label:
619-
"Step 6d: TH reads Feature dependent(TSTAT.S.F08(PRES)) commands in
609+
"Step 6c: TH reads Feature dependent(TSTAT.S.F08(PRES)) commands in
620610
AcceptedCommandList"
621611
PICS: TSTAT.S.F08
622612
command: "readAttribute"
@@ -627,18 +617,7 @@ tests:
627617
contains: [6, 254]
628618

629619
- label:
630-
"Step 7a: TH reads Feature dependent(TSTAT.S.F08(PRES)) commands in
631-
the GeneratedCommandList attribute."
632-
PICS: TSTAT.S.Cfe.Rsp
633-
command: "readAttribute"
634-
attribute: "GeneratedCommandList"
635-
response:
636-
value: [0xFD] # AtomicResponse
637-
constraints:
638-
type: list
639-
640-
- label:
641-
"Step 7b: TH reads Feature dependent(TSTAT.S.F03(SCH)) commands in
620+
"Step 7a: TH reads Feature dependent(TSTAT.S.F03(SCH)) commands in
642621
GeneratedCommandList"
643622
PICS: TSTAT.S.F03
644623
command: "readAttribute"
@@ -649,12 +628,12 @@ tests:
649628
contains: [0]
650629

651630
- label:
652-
"Step 7c: TH reads optional command (GetRelayStatusLogResponse) in
653-
GeneratedCommandList"
654-
PICS: TSTAT.S.C04.Rsp
631+
"Step 7b: TH reads Feature dependent(TSTAT.S.F08(PRES)) commands in
632+
the GeneratedCommandList attribute."
633+
PICS: TSTAT.S.F08 & TSTAT.S.Cfe.Rsp
655634
command: "readAttribute"
656635
attribute: "GeneratedCommandList"
657636
response:
637+
value: [0xFD] # AtomicResponse
658638
constraints:
659639
type: list
660-
contains: [1]

src/app/tests/suites/certification/ci-pics-values

+1
Original file line numberDiff line numberDiff line change
@@ -1989,6 +1989,7 @@ TSTAT.S.A004a=1
19891989
TSTAT.S.A004e=1
19901990
TSTAT.S.A0050=1
19911991
TSTAT.S.A0051=0
1992+
TSTAT.S.A0052=0
19921993

19931994
TSTAT.S.M.MinSetpointDeadBandWritable=1
19941995
TSTAT.S.M.HVACSystemTypeConfigurationWritable=0

0 commit comments

Comments
 (0)