Apply suggestions from code review

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Author: nivi-apple

src/darwin/Framework/CHIP/MTRDevice.h

@@ -429,7 +429,7 @@ MTR_EXTERN NSString * const MTRDataVersionKey MTR_NEWLY_AVAILABLE;
  *
  * This is called when the MTRDevice object detects a change in the device configuration.
  *
- * The intention is that after this is called, the client should re-enumerate the device topology.
+ * The intention is that this is called whenever any of the things that usually don't change about a device might have changed.
  */
 - (void)deviceConfigurationChanged:(MTRDevice *)device MTR_NEWLY_AVAILABLE;
 

src/darwin/Framework/CHIP/MTRDevice.mm

@@ -372,9 +372,8 @@ @implementation MTRDevice {
     NSDate * _Nullable _lastSubscriptionFailureTime;
     MTRDeviceConnectivityMonitor * _connectivityMonitor;
 
-    // This boolean keeps track of any device configuration changes received in an attribute report
-    // and when the report ends, we notify the delegate. Device configuration changes include parts list,
-    // server list, device type list, accepted commands list, attribute list, cluster revision and feature map updates.
+    // This boolean keeps track of any device configuration changes received in an attribute report.
+    // If this is true when the report ends, we notify the delegate.
     BOOL _deviceConfigurationChanged;
 }
 
@@ -1128,7 +1127,7 @@ - (void)_noteDeviceConfigurationChanged:(NSArray<NSDictionary<NSString *, id> *>
         case MTRClusterDescriptorAttributeClusterRevisionID:
         case MTRClusterDescriptorAttributeFeatureMapID: {
             // If changes are detected, note that the device configuration has changed.
-            NSDictionary * cachedAttributeDataValue = [self _cachedAttributeValueForPath:attributePath];
+            MTRDeviceDataValueDictionary cachedAttributeDataValue = [self _cachedAttributeValueForPath:attributePath];
             if (cachedAttributeDataValue != nil && ![self _attributeDataValue:attribute[MTRDataKey] isEqualToDataValue:cachedAttributeDataValue]) {
                 _deviceConfigurationChanged = YES;
                 break;

src/darwin/Framework/CHIPTests/MTRDeviceTests.m

@@ -3021,7 +3021,6 @@ - (void)test032_MTRPathClassesEncoding
     XCTAssertEqualObjects(originalCommandPath, decodedCommandPath);
 }
 
-#ifdef DEBUG
 - (void)test033_TestMTRDeviceDeviceConfigurationChanged
 {
     // Ensure the test starts with clean slate.
@@ -3063,7 +3062,7 @@ - (void)test033_TestMTRDeviceDeviceConfigurationChanged
         XCTAssert(attributeReportsReceived > 0);
         for (NSDictionary<NSString *, id> * attributeDict in attributeReport) {
             MTRAttributePath * attributePath = attributeDict[MTRAttributePathKey];
-            XCTAssert(attributePath != nil);
+            XCTAssertNotNil(attributePath);
 
             XCTAssert(attributePath.cluster.unsignedLongValue == MTRClusterDescriptorID);
             XCTAssert(attributePath.attribute.unsignedLongValue == MTRClusterDescriptorAttributePartsListID);