Timeout for BDX log should be treated as an abort transfer on failure use case

nivi-apple · nivi-apple · commit 7c28d9c76629 · 2024-06-06T18:23:16.000-07:00
diff --git a/src/app/clusters/diagnostic-logs-server/BDXDiagnosticLogsProvider.cpp b/src/app/clusters/diagnostic-logs-server/BDXDiagnosticLogsProvider.cpp
@@ -230,14 +230,14 @@ void BDXDiagnosticLogsProvider::OnInternalError()
 {
     ChipLogError(BDX, "Internal Error");
     VerifyOrDo(mIsAcceptReceived, SendCommandResponse(StatusEnum::kDenied));
-    Reset();
+    mTransfer.AbortTransfer(GetBdxStatusCodeFromChipError(CHIP_ERROR_INTERNAL));
 }
 
 void BDXDiagnosticLogsProvider::OnTimeout()
 {
     ChipLogError(BDX, "Timeout");
     VerifyOrDo(mIsAcceptReceived, SendCommandResponse(StatusEnum::kDenied));
-    Reset();
+    mTransfer.AbortTransfer(GetBdxStatusCodeFromChipError(CHIP_ERROR_TIMEOUT));
 }
 
 void BDXDiagnosticLogsProvider::SendCommandResponse(StatusEnum status)

Original file line number	Diff line number	Diff line change
`@@ -230,14 +230,14 @@ void BDXDiagnosticLogsProvider::OnInternalError()`
`230`	`230`	`{`
`231`	`231`	`ChipLogError(BDX, "Internal Error");`
`232`	`232`	`VerifyOrDo(mIsAcceptReceived, SendCommandResponse(StatusEnum::kDenied));`
`233`		`- Reset();`
	`233`	`+ mTransfer.AbortTransfer(GetBdxStatusCodeFromChipError(CHIP_ERROR_INTERNAL));`
`234`	`234`	`}`
`235`	`235`
`236`	`236`	`void BDXDiagnosticLogsProvider::OnTimeout()`
`237`	`237`	`{`
`238`	`238`	`ChipLogError(BDX, "Timeout");`
`239`	`239`	`VerifyOrDo(mIsAcceptReceived, SendCommandResponse(StatusEnum::kDenied));`
`240`		`- Reset();`
	`240`	`+ mTransfer.AbortTransfer(GetBdxStatusCodeFromChipError(CHIP_ERROR_TIMEOUT));`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`void BDXDiagnosticLogsProvider::SendCommandResponse(StatusEnum status)`