Skip to content

Commit a080ab7

Browse files
Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
1 parent 7a09a12 commit a080ab7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/darwin/Framework/CHIP/MTRDevice.mm

+4-4
Original file line numberDiff line numberDiff line change
@@ -2802,8 +2802,8 @@ - (void)_pruneOrphanedEndpointsAndClusters:(MTRAttributePath *)attributePath
28022802
// If the server list changed and clusters were removed, remove the clusters from the _persistedClusters and _persistedClusterData for that endpoint
28032803
// Also remove it from the data store.
28042804
case MTRAttributeIDTypeClusterDescriptorAttributeServerListID: {
2805-
NSMutableSet * toBeRemovedClusters = [NSMutableSet setWithArray:[self arrayOfNumbersFromAttributeValue:previousValue]];
2806-
NSSet * clustersOnDevice = [NSSet setWithArray:[self arrayOfNumbersFromAttributeValue:attributeDataValue]];
2805+
NSMutableSet<NSNumber *> * toBeRemovedClusters = [NSMutableSet setWithArray:[self arrayOfNumbersFromAttributeValue:previousValue]];
2806+
NSSet<NSNumber *> * clustersStillOnEndpoint = [NSSet setWithArray:[self arrayOfNumbersFromAttributeValue:attributeDataValue]];
28072807
[toBeRemovedClusters minusSet:clustersOnDevice];
28082808

28092809
NSMutableSet<MTRClusterPath *> * clusterPathsToRemove = [[NSMutableSet alloc] init];
@@ -2827,8 +2827,8 @@ - (void)_pruneOrphanedEndpointsAndClusters:(MTRAttributePath *)attributePath
28272827
// If the attribute list changed and attributes were removed, remove the attributes from the _persistedClusterData for that cluster and endpoint.
28282828
// Also remove it from the data store cluster data.
28292829
case MTRAttributeIDTypeGlobalAttributeAttributeListID: {
2830-
NSMutableSet * toBeRemovedAttributes = [NSMutableSet setWithArray:[self arrayOfNumbersFromAttributeValue:[self _cachedAttributeValueForPath:attributePath]]];
2831-
NSSet * attributesOnDevice = [NSSet setWithArray:[self arrayOfNumbersFromAttributeValue:attributeDataValue]];
2830+
NSMutableSet<NSNumber *> * toBeRemovedAttributes = [NSMutableSet setWithArray:[self arrayOfNumbersFromAttributeValue:[self _cachedAttributeValueForPath:attributePath]]];
2831+
NSSet<NSNumber *> * attributesStillIncluster = [NSSet setWithArray:[self arrayOfNumbersFromAttributeValue:attributeDataValue]];
28322832

28332833
[toBeRemovedAttributes minusSet:attributesOnDevice];
28342834
for (NSNumber * attribute in toBeRemovedAttributes) {

src/darwin/Framework/CHIP/MTRDeviceControllerDataStore.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ typedef void (^MTRDeviceControllerDataStoreClusterDataHandler)(NSDictionary<NSNu
7676
- (nullable MTRDeviceClusterData *)getStoredClusterDataForNodeID:(NSNumber *)nodeID endpointID:(NSNumber *)endpointID clusterID:(NSNumber *)clusterID;
7777
- (void)storeClusterData:(NSDictionary<MTRClusterPath *, MTRDeviceClusterData *> *)clusterData forNodeID:(NSNumber *)nodeID;
7878
- (void)clearStoredClusterDataForNodeID:(NSNumber *)nodeID;
79-
- (void)clearStoredClusterDataForNodeIDWithEndpointID:(NSNumber *)nodeID endpointID:(NSNumber *)endpointID;
80-
- (void)clearStoredClusterDataForNodeIDWithClusterID:(NSNumber *)nodeID endpointID:(NSNumber *)endpointID clusterID:(NSNumber *)clusterID;
79+
- (void)clearStoredClusterDataForNodeID:(NSNumber *)nodeID endpointID:(NSNumber *)endpointID;
80+
- (void)clearStoredClusterDataForNodeID:(NSNumber *)nodeID endpointID:(NSNumber *)endpointID clusterID:(NSNumber *)clusterID;
8181
- (void)clearAllStoredClusterData;
8282

8383
/**

0 commit comments

Comments
 (0)