Update pigweed to the latest version (project-chip#35644)

* Pull latest pigweed

* Make pigweed pull python 3.11 on macs, to have a consistent build environment

* Restyle

* Remove unused import

* Update signature of WriteLine - this was updated in pigwed to use std::string_view pass by value

* Workaround for slc errors for efr32

* Disable openssl warning of invalid function cast. This is already covered in connect.c via OPENSSL_MSVC_PRAGMA and is intentional

* ZAP regen because we change clang-format version

* SystemConfig includes ICDServerBuildConfig.h. Add the dependency as a formal dependency

* Fix typo in WriteLine parameter

* Restyle

* Fix the typo .. again, I had deleted the wrong thing

* Look to fix openiot sdk build

* Restyle

* Fix clang-tidy: it became stricter on unused arguments

* Fix tidy run for real this time ... at least one file passes locally

* Different fix for clang-tidy, seems more targeted

* More updates: -S is also a flag that clang tidy would not like according to https://github.com/llvm/llvm-project/pull/101103/files

* Fix typo

* Disable two more diagnostics that seem to show up in clang-tidy

* Need comma for - updated config

* Fix some clang-tidy findings

* More clang-tidy fixes

* Generate script update: make sure metadata is generated

* more tidy and dependency fixes

* more clang tidy make happy updates

* Restyle

* Fix too many args error

* Clean up an odd dependency

* Signature update for android test functions

* Fix type cast for android callback on type

* Fix the order of checks in TCP endpoint implementations to be what tests expect ... ugly that we verify input args first

* Fix invalid verify

* Fix typo

* Additional socket checks for socket inet implementations

* Self-review update

* Undo merge error

* Undo pigweed repo loss

* One more extra check to make clang-tidy happy

* One more extra check to make clang-tidy happy

* Switch to nolint

* Avoid large code deltas

* Restyle

* Restyled by clang-format

* Undo changes to build of attestation_verifier: it seems not needed

* Fix for clang-tidy requiring updated template keywords

* Fix the template argument ... there is a 2nd invoke type

* Another fix

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>

Author: 3 people

.clang-tidy

@@ -24,6 +24,7 @@ Checks: >
   -bugprone-multi-level-implicit-pointer-conversion,
   -bugprone-narrowing-conversions,
   -bugprone-not-null-terminated-result,
+  -bugprone-pointer-arithmetic-on-polymorphic-object,
   -bugprone-reserved-identifier,
   -bugprone-signed-char-misuse,
   -bugprone-suspicious-include,
@@ -45,6 +46,7 @@ Checks: >
   -clang-analyzer-security.insecureAPI.rand,
   -clang-analyzer-security.insecureAPI.strcpy,
   -clang-analyzer-unix.Malloc,
-  -clang-diagnostic-implicit-int-conversion
+  -clang-diagnostic-implicit-int-conversion,
+  -clang-diagnostic-missing-template-arg-list-after-template-kw
 WarningsAsErrors: '*'
 HeaderFilterRegex: '(src|examples|zzz_generated|credentials).*(?<!third_party.*repo)'

examples/platform/ameba/pw_sys_io/sys_io_ameba.cc

@@ -69,7 +69,7 @@ Status WriteByte(std::byte b)
 }
 
 // Writes a string using pw::sys_io, and add newline characters at the end.
-StatusWithSize WriteLine(const std::string_view & s)
+StatusWithSize WriteLine(std::string_view s)
 {
     size_t chars_written  = 0;
     StatusWithSize result = WriteBytes(pw::as_bytes(pw::span(s)));