Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tests: Package Server Components and Use AutoScript from Source #202

Open
6 tasks
nilp0inter opened this issue Mar 4, 2025 · 0 comments
Open
6 tasks
Assignees
Labels
autofirma dependencies enhancement New feature or request tests under investigation This issue is currently being reviewed

Comments

@nilp0inter
Copy link
Collaborator

Currently, the test infrastructure for autofirma-nix relies on downloading prebuilt WAR files for the server components and fetching the latest release of AutoScript. This introduces potential inconsistencies between what we package and what we test.

To improve test reliability and ensure alignment with upstream, we should:

  1. Package the following server components instead of downloading the official WARs:
    • afirma-server-triphase-signer.war
    • afirma-signature-retriever.war
    • afirma-signature-storage.war
  2. Use these packaged versions in tests rather than relying on the official published binaries.
  3. Fetch AutoScript directly from the source repository instead of using the latest release.

Benefits

  • Ensures tests are in sync with the packaged version of AutoFirma.
  • Prevents issues caused by upstream changes in published binaries that we don't control.
  • Reduces external dependencies, making tests more reproducible.
  • Aligns with the Nix philosophy of building everything from source when possible.

Next Steps

  • Investigate the necessary dependencies and build steps for packaging:
    • afirma-server-triphase-signer
    • afirma-signature-retriever
    • afirma-signature-storage
  • Modify tests to use these packaged versions instead of downloading WAR files.
  • Adjust the test setup to fetch AutoScript from the source repository instead of using a prebuilt release.
@nilp0inter nilp0inter added autofirma dependencies enhancement New feature or request tests under investigation This issue is currently being reviewed labels Mar 4, 2025
@nilp0inter nilp0inter self-assigned this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autofirma dependencies enhancement New feature or request tests under investigation This issue is currently being reviewed
Projects
None yet
Development

No branches or pull requests

1 participant