You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After the changes in #5516 and #6478 my XDG_CONFIG_HOME/git/config started depending on the gnupg package on stateVersion = 24.05, even though I do not set anything in programs.git.signing. The problem is this check:
The signing attrset is never empty, and because stateVersion < 24.11 the default value for signing.format is openpgp, which sets iniContent.gpg.openpgp.program = pkgs.gnupg.
I'm willing to write a PR to fix this, but I'm not sure how to proceed here, because we don't have a clear way of checking whether any value in programs.git.signing was actually set by the user. So to properly fix this I see two options: either go back to using a submodule for programs.git.signing, or add a programs.git.signing.enable option.
I'm willing to write a PR to fix this, but I'm not sure how to proceed here, because we don't have a clear way of checking whether any value in programs.git.signing was actually set by the user.
Can check if the option is the default priority like I did with a recent home-cursor change. When a user sets an option, it will have a different priority.
That doesn't work in this case, because options.programs.git.signing is a simple attrset containing some options, not a lib.mkOption { type = lib.types.submodule; }.
Are you following the right branch?
Is there an existing issue for this?
Issue description
After the changes in #5516 and #6478 my
XDG_CONFIG_HOME/git/config
started depending on thegnupg
package onstateVersion = 24.05
, even though I do not set anything inprograms.git.signing
. The problem is this check:home-manager/modules/programs/git.nix
Line 517 in 6f71acf
The
signing
attrset is never empty, and becausestateVersion < 24.11
the default value forsigning.format
isopenpgp
, which setsiniContent.gpg.openpgp.program = pkgs.gnupg
.I'm willing to write a PR to fix this, but I'm not sure how to proceed here, because we don't have a clear way of checking whether any value in
programs.git.signing
was actually set by the user. So to properly fix this I see two options: either go back to using a submodule forprograms.git.signing
, or add aprograms.git.signing.enable
option.Maintainer CC
@rycee @khaneliman
Also pinging @Prince213 as author of #5516
System information
The text was updated successfully, but these errors were encountered: