Skip to content

Commit 1b28ccd

Browse files
simensrostadsimensrostad
committed
wmodules: Remove logging in _run SMF functions
Remove logging in `_run` SMF functions to avoid bloating application logs. Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
1 parent 73bbe09 commit 1b28ccd

File tree

4 files changed

+0
-41
lines changed

4 files changed

+0
-41
lines changed

‎app/src/modules/app/app.c

-16
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,6 @@ static void running_run(void *o)
258258
{
259259
struct state_object *user_object = o;
260260

261-
LOG_DBG("%s", __func__);
262-
263261
if (user_object->chan == &FOTA_CHAN) {
264262
if (user_object->fota_status == FOTA_DOWNLOADING_UPDATE) {
265263
STATE_SET(app_state, STATE_FOTA);
@@ -304,8 +302,6 @@ static void idle_run(void *o)
304302
{
305303
struct state_object *user_object = o;
306304

307-
LOG_DBG("%s", __func__);
308-
309305
if ((user_object->chan == &CLOUD_CHAN) &&
310306
(user_object->status == CLOUD_CONNECTED_READY_TO_SEND)) {
311307
LOG_DBG("Cloud connected and ready, going into periodic triggering state");
@@ -350,8 +346,6 @@ static void periodic_triggering_run(void *o)
350346
{
351347
struct state_object *user_object = o;
352348

353-
LOG_DBG("%s", __func__);
354-
355349
if ((user_object->chan == &CLOUD_CHAN) &&
356350
((user_object->status == CLOUD_CONNECTED_PAUSED) ||
357351
(user_object->status == CLOUD_DISCONNECTED))) {
@@ -387,8 +381,6 @@ static void fota_run(void *o)
387381
{
388382
struct state_object *user_object = o;
389383

390-
LOG_DBG("%s", __func__);
391-
392384
if (user_object->chan == &FOTA_CHAN) {
393385
switch (user_object->fota_status) {
394386
case FOTA_CANCELED:
@@ -432,8 +424,6 @@ static void fota_network_disconnect_pending_run(void *o)
432424
{
433425
struct state_object *user_object = o;
434426

435-
LOG_DBG("%s", __func__);
436-
437427
if (user_object->chan == &NETWORK_CHAN) {
438428
if (user_object->network_status == NETWORK_DISCONNECTED) {
439429
STATE_SET(app_state, STATE_FOTA_IMAGE_APPLY_PENDING);
@@ -464,8 +454,6 @@ static void fota_image_apply_pending_run(void *o)
464454
{
465455
struct state_object *user_object = o;
466456

467-
LOG_DBG("%s", __func__);
468-
469457
if (user_object->chan == &FOTA_CHAN) {
470458
if (user_object->fota_status == FOTA_REBOOT_NEEDED) {
471459
STATE_SET(app_state, STATE_FOTA_REBOOTING);
@@ -498,8 +486,6 @@ static void app_callback(const struct zbus_channel *chan)
498486
{
499487
int err;
500488

501-
LOG_DBG("Received message on channel %s", zbus_chan_name(chan));
502-
503489
/* Update the state object with the channel that the message was received on */
504490
app_state.chan = chan;
505491

@@ -524,8 +510,6 @@ static void app_callback(const struct zbus_channel *chan)
524510
app_state.network_status = network_msg->type;
525511
}
526512

527-
LOG_DBG("Running SMF");
528-
529513
/* State object updated, run SMF */
530514
err = STATE_RUN(app_state);
531515
if (err) {

‎app/src/modules/cloud/cloud_module.c

-11
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,6 @@ static void state_running_run(void *o)
326326
{
327327
struct state_object *state_object = o;
328328

329-
LOG_DBG("%s", __func__);
330-
331329
if (state_object->chan == &NETWORK_CHAN) {
332330
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
333331

@@ -361,9 +359,6 @@ static void state_disconnected_entry(void *o)
361359
static void state_disconnected_run(void *o)
362360
{
363361
struct state_object const *state_object = o;
364-
365-
LOG_DBG("%s", __func__);
366-
367362
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
368363

369364
if ((state_object->chan == &NETWORK_CHAN) && (msg.type == NETWORK_CONNECTED)) {
@@ -415,8 +410,6 @@ static void state_connecting_backoff_run(void *o)
415410
{
416411
struct state_object *state_object = o;
417412

418-
LOG_DBG("%s", __func__);
419-
420413
if (state_object->chan == &PRIV_CLOUD_CHAN) {
421414
enum priv_cloud_msg msg = *(enum priv_cloud_msg *)state_object->msg_buf;
422415

@@ -515,8 +508,6 @@ static void state_connected_ready_run(void *o)
515508
int err;
516509
struct state_object *state_object = o;
517510

518-
LOG_DBG("%s", __func__);
519-
520511
if (state_object->chan == &NETWORK_CHAN) {
521512
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
522513

@@ -653,8 +644,6 @@ static void state_connected_paused_run(void *o)
653644
struct state_object *state_object = o;
654645
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
655646

656-
LOG_DBG("%s", __func__);
657-
658647
if ((state_object->chan == &NETWORK_CHAN) && (msg.type == NETWORK_CONNECTED)) {
659648
STATE_SET(cloud_state, STATE_CONNECTED_READY);
660649

‎app/src/modules/location/location.c

-2
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ void location_task(void)
219219
}
220220

221221
if (&NETWORK_CHAN == chan) {
222-
LOG_DBG("Network status received");
223222
handle_network_chan(MSG_TO_NETWORK_MSG(&msg_buf));
224223
}
225224

@@ -228,7 +227,6 @@ void location_task(void)
228227
}
229228

230229
if (&CONFIG_CHAN == chan) {
231-
LOG_DBG("Configuration received");
232230
handle_config_chan(MSG_TO_CONFIGURATION(&msg_buf));
233231
}
234232
}

‎app/src/modules/network/network.c

-12
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,6 @@ static void state_running_run(void *obj)
341341
{
342342
struct network_state_object const *state_object = obj;
343343

344-
LOG_DBG("state_running_run");
345-
346344
if (&NETWORK_CHAN == state_object->chan) {
347345
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
348346

@@ -388,8 +386,6 @@ static void state_disconnected_run(void *obj)
388386
{
389387
struct network_state_object const *state_object = obj;
390388

391-
LOG_DBG("state_disconnected_run");
392-
393389
if (&NETWORK_CHAN == state_object->chan) {
394390
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
395391

@@ -436,8 +432,6 @@ static void state_disconnected_searching_run(void *obj)
436432
{
437433
struct network_state_object const *state_object = obj;
438434

439-
LOG_DBG("state_disconnected_searching_run");
440-
441435
if (&NETWORK_CHAN == state_object->chan) {
442436
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
443437

@@ -460,8 +454,6 @@ static void state_disconnected_idle_run(void *obj)
460454
int err;
461455
struct network_state_object const *state_object = obj;
462456

463-
LOG_DBG("state_disconnected_idle_run");
464-
465457
if (&NETWORK_CHAN == state_object->chan) {
466458
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
467459

@@ -513,8 +505,6 @@ static void state_connected_run(void *obj)
513505
{
514506
struct network_state_object const *state_object = obj;
515507

516-
LOG_DBG("state_connected_run");
517-
518508
if (&NETWORK_CHAN == state_object->chan) {
519509
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
520510

@@ -552,8 +542,6 @@ static void state_disconnecting_run(void *obj)
552542
{
553543
struct network_state_object const *state_object = obj;
554544

555-
LOG_DBG("state_disconnecting_run");
556-
557545
if (&NETWORK_CHAN == state_object->chan) {
558546
struct network_msg msg = MSG_TO_NETWORK_MSG(state_object->msg_buf);
559547

0 commit comments

Comments
 (0)