modules: fota: remove FOTA_STATUS_CHAN

FOTA_STATUS_CHAN is an old relic, not needed anymore.

Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>

Author: DematteisGiacomo

app/src/common/message_channel.c

@@ -18,14 +18,6 @@ ZBUS_CHAN_DEFINE(TRIGGER_CHAN,
 		 ZBUS_MSG_INIT(0)
 );
 
-ZBUS_CHAN_DEFINE(FOTA_STATUS_CHAN,
-		 enum fota_status,
-		 NULL,
-		 NULL,
-		 ZBUS_OBSERVERS_EMPTY,
-		 ZBUS_MSG_INIT(0)
-);
-
 ZBUS_CHAN_DEFINE(NETWORK_CHAN,
 		 struct network_msg,
 		 NULL,

app/src/common/message_channel.h

@@ -201,26 +201,6 @@ enum error_type {
 	ERROR_IRRECOVERABLE,
 };
 
-/** @brief Status sent from the FOTA module on the FOTA_STATUS_CHAN channel. */
-enum fota_status {
-	/* No FOTA job is ongoing */
-	FOTA_STATUS_IDLE = 0x1,
-
-	/* FOTA started. */
-	FOTA_STATUS_START,
-
-	/* FOTA stopped. */
-	FOTA_STATUS_STOP,
-
-	/* A firmware image has been downloaded and a reboot is required to apply it.
-	 * The FOTA module will perform the reboot CONFIG_APP_FOTA_REBOOT_DELAY_SECONDS seconds
-	 * after this status is sent.
-	 */
-	FOTA_STATUS_REBOOT_PENDING,
-};
-
-#define MSG_TO_FOTA_STATUS(_msg) (*(const enum fota_status *)_msg)
-
 struct configuration {
 	/* LED */
 	int led_red;
@@ -244,7 +224,6 @@ struct configuration {
 ZBUS_CHAN_DECLARE(
 	CONFIG_CHAN,
 	ERROR_CHAN,
-	FOTA_STATUS_CHAN,
 	LED_CHAN,
 	NETWORK_CHAN,
 	TIME_CHAN,

app/src/modules/fota/fota.c

@@ -236,16 +236,8 @@ static void state_reboot_pending_entry(void *o)
 	ARG_UNUSED(o);
 
 	int err;
-	enum fota_status fota_status = FOTA_STATUS_REBOOT_PENDING;
 	struct nrf_cloud_settings_fota_job job = { .validate = NRF_CLOUD_FOTA_VALIDATE_NONE };
 
-	/* Notify the rest of the system that a reboot is pending */
-	err = zbus_chan_pub(&FOTA_STATUS_CHAN, &fota_status, K_SECONDS(1));
-	if (err) {
-		LOG_ERR("zbus_chan_pub, error: %d", err);
-		SEND_FATAL_ERROR();
-	}
-
 	/* Check if validation of full modem FOTA failed, if so, try again...
 	 * This is a workaround due to modem shutdown -> reinitialization in bootloader mode fails
 	 * quite frequently. (Needed to apply the full modem image)
@@ -322,20 +314,6 @@ static void fota_reboot(enum nrf_cloud_fota_reboot_status status)
 	 */
 }
 
-static void status_events_notify(enum fota_status status)
-{
-	int err;
-
-	enum fota_status fota_status = status;
-
-	err = zbus_chan_pub(&FOTA_STATUS_CHAN, &fota_status, K_SECONDS(1));
-	if (err) {
-		LOG_ERR("zbus_chan_pub, error: %d", err);
-		SEND_FATAL_ERROR();
-		return;
-	}
-}
-
 static void fota_status(enum nrf_cloud_fota_status status, const char *const status_details)
 {
 	int err;
@@ -351,23 +329,15 @@ static void fota_status(enum nrf_cloud_fota_status status, const char *const sta
 	switch (status) {
 	case NRF_CLOUD_FOTA_DOWNLOADING:
 		LOG_DBG("Downloading firmware update");
-
-		status_events_notify(FOTA_STATUS_START);
 		return;
 	case NRF_CLOUD_FOTA_FAILED:
 		LOG_ERR("Firmware download failed");
-
-		status_events_notify(FOTA_STATUS_STOP);
 		break;
 	case NRF_CLOUD_FOTA_TIMED_OUT:
 		LOG_ERR("Firmware download timed out");
-
-		status_events_notify(FOTA_STATUS_STOP);
 		break;
 	case NRF_CLOUD_FOTA_SUCCEEDED:
 		LOG_DBG("Firmware update succeeded");
-
-		status_events_notify(FOTA_STATUS_STOP);
 		return;
 	default:
 		LOG_ERR("Unknown FOTA status: %d", status);