Skip to content

Commit 25cc5cf

Browse files
workflows: fix memfault elf upload
9151dk and thingy91x are currently racing for memfault upload. This should fix it.
1 parent 4f9251f commit 25cc5cf

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.github/workflows/build.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ jobs:
101101
echo "CONFIG_MEMFAULT_NCS_PROJECT_KEY=\"${{ secrets.MEMFAULT_PROJECT_KEY }}\"" >> overlay-memfault-att.conf
102102
echo CONFIG_MEMFAULT_NCS_FW_VERSION_STATIC=y >> overlay-memfault-att.conf
103103
echo CONFIG_MEMFAULT_NCS_FW_VERSION=\"${{ env.VERSION }}\" >> overlay-memfault-att.conf
104-
echo CONFIG_MEMFAULT_NCS_FW_TYPE=\"${{ env.MEMFAULT_SW_TYPE }}\" >> overlay-memfault-att.conf
104+
echo CONFIG_MEMFAULT_NCS_FW_TYPE=\"${{ env.MEMFAULT_SW_TYPE }}-thingy91x\" >> overlay-memfault-att.conf
105105
west build -b thingy91x/nrf9151/ns -d build -p --sysbuild -- -DEXTRA_CONF_FILE="overlay-memfault-att.conf"
106106
cp build/merged.hex artifacts/asset-tracker-template-${{ env.VERSION }}-thingy91x-nrf91.hex
107107
cp build/app/zephyr/.config artifacts/asset-tracker-template-${{ env.VERSION }}-thingy91x-nrf91.config
@@ -122,7 +122,7 @@ jobs:
122122
echo "CONFIG_MEMFAULT_NCS_PROJECT_KEY=\"${{ secrets.MEMFAULT_PROJECT_KEY }}\"" >> overlay-memfault-att.conf
123123
echo CONFIG_MEMFAULT_NCS_FW_VERSION_STATIC=y >> overlay-memfault-att.conf
124124
echo CONFIG_MEMFAULT_NCS_FW_VERSION=\"${{ env.VERSION }}\" >> overlay-memfault-att.conf
125-
echo CONFIG_MEMFAULT_NCS_FW_TYPE=\"${{ env.MEMFAULT_SW_TYPE }}\" >> overlay-memfault-att.conf
125+
echo CONFIG_MEMFAULT_NCS_FW_TYPE=\"${{ env.MEMFAULT_SW_TYPE }}-nrf9151dk\" >> overlay-memfault-att.conf
126126
west build -b nrf9151dk/nrf9151/ns -d build -p --sysbuild -- -DEXTRA_CONF_FILE="overlay-memfault-att.conf"
127127
cp build/merged.hex artifacts/asset-tracker-template-${{ env.VERSION }}-nrf9151dk-nrf91.hex
128128
cp build/app/zephyr/.config artifacts/asset-tracker-template-${{ env.VERSION }}-nrf9151dk-nrf91.config
@@ -153,7 +153,7 @@ jobs:
153153
echo "CONFIG_MEMFAULT_NCS_PROJECT_KEY=\"${{ secrets.MEMFAULT_PROJECT_KEY }}\"" >> overlay-memfault-debug.conf
154154
echo CONFIG_MEMFAULT_NCS_FW_VERSION_STATIC=y >> overlay-memfault-debug.conf
155155
echo CONFIG_MEMFAULT_NCS_FW_VERSION=\"${{ env.VERSION }}-debug\" >> overlay-memfault-debug.conf
156-
echo CONFIG_MEMFAULT_NCS_FW_TYPE=\"${{ env.MEMFAULT_SW_TYPE }}\" >> overlay-memfault-debug.conf
156+
echo CONFIG_MEMFAULT_NCS_FW_TYPE=\"${{ env.MEMFAULT_SW_TYPE }}-thingy91x\" >> overlay-memfault-debug.conf
157157
west build -p -b thingy91x/nrf9151/ns -p --sysbuild -- -DEXTRA_CONF_FILE="overlay-memfault-debug.conf;overlay-etb.conf"
158158
159159
- name: Rename debug artifacts

.github/workflows/publish-symbol-files-to-memfault.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
--org ${{ vars.MEMFAULT_ORGANIZATION_SLUG }} \
4141
--project ${{ vars.MEMFAULT_PROJECT_SLUG }} \
4242
upload-mcu-symbols \
43-
--software-type asset-tracker-template \
43+
--software-type asset-tracker-template-thingy91x \
4444
--software-version ${{ inputs.version }} \
4545
asset-tracker-template-${{ inputs.version }}-thingy91x-nrf91.elf
4646
@@ -49,7 +49,7 @@ jobs:
4949
--org ${{ vars.MEMFAULT_ORGANIZATION_SLUG }} \
5050
--project ${{ vars.MEMFAULT_PROJECT_SLUG }} \
5151
upload-mcu-symbols \
52-
--software-type asset-tracker-template \
52+
--software-type asset-tracker-template-nrf9151dk \
5353
--software-version ${{ inputs.version }} \
5454
asset-tracker-template-${{ inputs.version }}-nrf9151dk-nrf91.elf
5555
@@ -61,6 +61,6 @@ jobs:
6161
--org ${{ vars.MEMFAULT_ORGANIZATION_SLUG }} \
6262
--project ${{ vars.MEMFAULT_PROJECT_SLUG }} \
6363
upload-mcu-symbols \
64-
--software-type asset-tracker-template \
64+
--software-type asset-tracker-template-thingy91x \
6565
--software-version ${{ inputs.version }}-debug \
6666
asset-tracker-template-${{ inputs.version }}-debug-thingy91x-nrf91.elf

.github/workflows/target-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
--org ${{ vars.MEMFAULT_ORGANIZATION_SLUG }} \
105105
--project ${{ vars.MEMFAULT_PROJECT_SLUG }} \
106106
upload-mcu-symbols \
107-
--software-type asset-tracker-template-ci \
107+
--software-type asset-tracker-template-ci-${{ matrix.device }} \
108108
--software-version ${{ inputs.artifact_fw_version }} \
109109
asset-tracker-template-${{ inputs.artifact_fw_version }}-${{ matrix.device }}-nrf91.elf
110110

0 commit comments

Comments
 (0)