workflows: compliance: remove continue-on-error

Compliance is not failing on error, This should fix it.
Added error state tracking using GitHub environment variables.
Combined the two duplicate check-warns steps into a single more comprehensive Process Compliance Results step.
Improved formatting for readability.

Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>

Author: DematteisGiacomo

.github/workflows/compliance.yml

@@ -16,56 +16,84 @@ jobs:
     if: ${{ !contains(github.actor, 'renovate') }}
 
     steps:
-    - name: Checkout the code
-      uses: actions/checkout@v4
-      with:
-        path: asset-tracker-template
-        ref: ${{ github.event.pull_request.head.sha }}
-        fetch-depth: 0
+      - name: Checkout the code
+        uses: actions/checkout@v4
+        with:
+          path: asset-tracker-template
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 0
 
-    - name: Initialize
-      working-directory: asset-tracker-template
-      run: |
-        west init -l .
-        west config manifest.group-filter +bsec
-        west config build.sysbuild True
-        west update -o=--depth=1 -n
-        west blobs fetch hal_nordic
+      - name: Initialize
+        working-directory: asset-tracker-template
+        run: |
+          west init -l .
+          west config manifest.group-filter +bsec
+          west config build.sysbuild True
+          west update -o=--depth=1 -n
+          west blobs fetch hal_nordic
 
-    - name: Run Compliance Tests
-      continue-on-error: true
-      id: compliance
-      shell: bash
-      env:
-        BASE_REF: ${{ github.base_ref }}
-      working-directory: asset-tracker-template
-      run: |
-        export ZEPHYR_BASE="../zephyr"
-        $ZEPHYR_BASE/scripts/ci/check_compliance.py -m Codeowners -m Devicetree -m Gitlint -m Identity -m Nits -m pylint -m checkpatch -m KconfigBasic -c origin/${BASE_REF}..
+      - name: Run Compliance Tests
+        id: compliance
+        shell: bash
+        env:
+          BASE_REF: ${{ github.base_ref }}
+        working-directory: asset-tracker-template
+        run: |
+          export ZEPHYR_BASE="../zephyr"
+          $ZEPHYR_BASE/scripts/ci/check_compliance.py \
+            -m Codeowners \
+            -m Devicetree \
+            -m Gitlint \
+            -m Identity \
+            -m Nits \
+            -m pylint \
+            -m checkpatch \
+            -m KconfigBasic \
+            -c origin/${BASE_REF}.. || \
+          echo "COMPLIANCE_FAILED=true" >> $GITHUB_ENV
 
-    - name: check-warns
-      working-directory: asset-tracker-template
-      shell: bash
-      run: |
-        if [[ ! -s "compliance.xml" ]]; then
-          exit 1;
-        fi
+      - name: Process Compliance Results
+        working-directory: asset-tracker-template
+        shell: bash
+        run: |
+          # Check for compliance.xml existence
+          if [[ ! -s "compliance.xml" ]]; then
+            echo "::error::compliance.xml file is missing or empty"
+            exit 1
+          fi
+
+          # Initialize exit code
+          exit_code=0
+
+          # Define error files to check
+          error_files=(
+            "Nits.txt"
+            "checkpatch.txt"
+            "Identity.txt"
+            "Gitlint.txt"
+            "pylint.txt"
+            "Devicetree.txt"
+            "Kconfig.txt"
+            "KconfigBasic.txt"
+            "Codeowners.txt"
+          )
+
+          # Process each error file
+          for file in "${error_files[@]}"; do
+            if [[ -s $file ]]; then
+              errors=$(cat $file)
+              errors="${errors//'%'/'%25'}"
+              errors="${errors//$'\n'/'%0A'}"
+              errors="${errors//$'\r'/'%0D'}"
+              echo "::error file=${file}::$errors"
+              exit_code=1
+            fi
+          done
 
-    - name: check-warns
-      working-directory: asset-tracker-template
-      shell: bash
-      run: |
-        for file in Nits.txt checkpatch.txt Identity.txt Gitlint.txt pylint.txt Devicetree.txt Kconfig.txt KconfigBasic.txt Codeowners.txt; do
-          if [[ -s $file ]]; then
-             errors=$(cat $file)
-             errors="${errors//'%'/'%25'}"
-             errors="${errors//$'\n'/'%0A'}"
-             errors="${errors//$'\r'/'%0D'}"
-             echo "::error file=${file}::$errors"
-             exit=1
+          # Check if compliance test failed
+          if [[ "$COMPLIANCE_FAILED" == "true" ]]; then
+            echo "::error::Compliance tests failed. Please check the logs for details."
+            exit_code=1
           fi
-        done
 
-        if [[ $exit == 1 ]]; then
-          exit 1
-        fi
+          exit $exit_code