Skip to content

Commit 3047bf1

Browse files
[nrf noup] Repair Factory data script after sysbuild
Factory data script must use the original configs instead of the new ones created by sysbuild.
1 parent 2540dfe commit 3047bf1

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

config/nrfconnect/chip-module/Kconfig

-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ config CHIP_OTA_REQUESTOR_REBOOT_ON_APPLY
8787
config CHIP_OTA_IMAGE_BUILD
8888
bool
8989
default y if CHIP_OTA_REQUESTOR
90-
depends on SIGN_IMAGES
9190
select DFU_MULTI_IMAGE_PACKAGE_BUILD
9291

9392
config CHIP_EXAMPLE_DEVICE_INFO_PROVIDER

config/nrfconnect/chip-module/generate_factory_data_sysbuild.cmake

+4-1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
# This argument is optional, if you don't want to verify the JSON file put it empty "".
3939
# output_path - a path to output directory, where created hex and JSON files will be stored.
4040
function(nrfconnect_create_factory_data factory_data_target script_path schema_path output_path image)
41+
sysbuild_get(CONFIG_CHIP_FACTORY_DATA_BUILD IMAGE ${image} VAR CONFIG_CHIP_FACTORY_DATA_BUILD KCONFIG)
4142
sysbuild_get(CONFIG_CHIP_DEVICE_SERIAL_NUMBER IMAGE ${image} VAR CONFIG_CHIP_DEVICE_SERIAL_NUMBER KCONFIG)
4243
sysbuild_get(CONFIG_CHIP_DEVICE_MANUFACTURING_DATE IMAGE ${image} VAR CONFIG_CHIP_DEVICE_MANUFACTURING_DATE KCONFIG)
4344
sysbuild_get(CONFIG_CHIP_DEVICE_VENDOR_ID IMAGE ${image} VAR CONFIG_CHIP_DEVICE_VENDOR_ID KCONFIG)
@@ -219,7 +220,9 @@ function(nrfconnect_generate_factory_data)
219220
${DEFAULT_IMAGE}
220221
)
221222

222-
if(SB_CONFIG_MATTER_FACTORY_DATA_MERGE_WITH_FIRMWARE)
223+
sysbuild_get(CONFIG_CHIP_FACTORY_DATA_MERGE_WITH_FIRMWARE IMAGE ${image} VAR CONFIG_CHIP_FACTORY_DATA_MERGE_WITH_FIRMWARE KCONFIG)
224+
225+
if(CONFIG_CHIP_FACTORY_DATA_MERGE_WITH_FIRMWARE)
223226
if(SB_CONFIG_PARTITION_MANAGER)
224227
# Set custom target for merging factory_data hex file
225228
set_property(GLOBAL PROPERTY factory_data_PM_HEX_FILE ${OUTPUT_FILE_PATH}/factory_data.hex)

0 commit comments

Comments
 (0)