Skip to content

Commit aa538d6

Browse files
[nrf toup][nrfconnect] Fixed mcuboot default configuration
Removed the defaults from Kconfig.mcuboot.defaults configuration that should not be set there: * BOOT_ENCRYPT_X - are configs without a prompt, so it should not be modified outside of the mcuboot module * SPI_NOR and NORDIC_QSPI_NOR - are set based on the device tree configuration, so we should not set it, as it may lead to configuration and dts mismatch. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
1 parent cb18255 commit aa538d6

File tree

3 files changed

+6
-27
lines changed

3 files changed

+6
-27
lines changed

config/nrfconnect/chip-module/Kconfig.defaults

+4-8
Original file line numberDiff line numberDiff line change
@@ -334,13 +334,9 @@ if PSA_CRYPTO_DRIVER_CC3XX && PSA_CRYPTO_DRIVER_OBERON
334334
config PSA_USE_CC3XX_HASH_DRIVER
335335
default n
336336

337-
endif
337+
endif # PSA_CRYPTO_DRIVER_CC3XX && PSA_CRYPTO_DRIVER_OBERON
338338

339-
# Spake2+ support
340-
config MBEDTLS_MD_C
341-
default y
342-
343-
endif
339+
endif # CHIP_CRYPTO_PSA
344340

345341
if !CHIP_CRYPTO_PSA
346342

@@ -383,7 +379,7 @@ config MBEDTLS_ECP_C
383379
config MBEDTLS_ECP_DP_SECP256R1_ENABLED
384380
default y
385381

386-
endif
382+
endif # !CHIP_CRYPTO_PSA
387383

388384
config MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG
389385
default n if CHIP_WIFI
@@ -509,4 +505,4 @@ config OPENTHREAD_SHELL
509505

510506
endif # SHELL
511507

512-
endif
508+
endif # CHIP

config/nrfconnect/chip-module/Kconfig.features

+1-3
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,13 @@ config CHIP_WIFI
4242

4343
config CHIP_QSPI_NOR
4444
bool "Enable QSPI NOR feature set"
45+
imply NORDIC_QSPI_NOR
4546
help
4647
Enables QSPI NOR flash with a set of options for configuring pages and
4748
buffer sizes.
4849

4950
if CHIP_QSPI_NOR
5051

51-
config NORDIC_QSPI_NOR
52-
default y
53-
5452
config NORDIC_QSPI_NOR_STACK_WRITE_BUFFER_SIZE
5553
default 16
5654

config/nrfconnect/chip-module/Kconfig.mcuboot.defaults

+1-16
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,7 @@
1919
config MAIN_STACK_SIZE
2020
default 10240
2121

22-
config BOOT_SWAP_SAVE_ENCTLV
23-
default n
24-
25-
config BOOT_ENCRYPT_RSA
26-
default n
27-
28-
config BOOT_ENCRYPT_EC256
29-
default n
30-
31-
config BOOT_ENCRYPT_X25519
22+
config BOOT_ENCRYPT_IMAGE
3223
default n
3324

3425
config BOOT_BOOTSTRAP
@@ -53,9 +44,6 @@ if BOARD_NRF7002DK_NRF5340_CPUAPP || BOARD_NRF7002DK_NRF7001_NRF5340_CPUAPP
5344
config SPI
5445
default y
5546

56-
config SPI_NOR
57-
default y
58-
5947
choice SPI_NOR_SFDP
6048
default SPI_NOR_SFDP_DEVICETREE
6149
endchoice
@@ -74,9 +62,6 @@ endif
7462
# All boards beside nRF7002DK use QSPI NOR external flash
7563
if BOARD_NRF5340DK_NRF5340_CPUAPP || BOARD_NRF52840DK_NRF52840
7664

77-
config NORDIC_QSPI_NOR
78-
default y
79-
8065
config NORDIC_QSPI_NOR_FLASH_LAYOUT_PAGE_SIZE
8166
default 4096
8267

0 commit comments

Comments
 (0)