Skip to content

Commit ca3672f

Browse files
committed
[mrp] Increase default retry interval for Thread
The current 800ms is not enough in real setups, where Thread routers must serve as intermediate hops for many parallel conversations. Bump this to 2s. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
1 parent 0987a50 commit ca3672f

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

src/messaging/ReliableMessageProtocolConfig.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ namespace chip {
5656
*/
5757
#ifndef CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL
5858
#if CHIP_ENABLE_OPENTHREAD && !CHIP_DEVICE_LAYER_TARGET_LINUX
59-
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (800_ms32)
59+
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (2000_ms32)
6060
#else
6161
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (300_ms32)
6262
#endif
@@ -82,7 +82,7 @@ namespace chip {
8282
*/
8383
#ifndef CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL
8484
#if CHIP_ENABLE_OPENTHREAD && !CHIP_DEVICE_LAYER_TARGET_LINUX
85-
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (800_ms32)
85+
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (2000_ms32)
8686
#else
8787
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (300_ms32)
8888
#endif
@@ -174,7 +174,7 @@ namespace chip {
174174
*/
175175
#ifndef CHIP_CONFIG_MRP_RETRY_INTERVAL_SENDER_BOOST
176176
#if CHIP_ENABLE_OPENTHREAD && !CHIP_DEVICE_LAYER_TARGET_LINUX
177-
#define CHIP_CONFIG_MRP_RETRY_INTERVAL_SENDER_BOOST (500_ms)
177+
#define CHIP_CONFIG_MRP_RETRY_INTERVAL_SENDER_BOOST (1500_ms)
178178
#else
179179
#define CHIP_CONFIG_MRP_RETRY_INTERVAL_SENDER_BOOST (0_ms)
180180
#endif

src/platform/nrfconnect/CHIPPlatformConfig.h

+4-9
Original file line numberDiff line numberDiff line change
@@ -106,21 +106,16 @@
106106
#define CHIP_CONFIG_LOG_MODULE_Support_PROGRESS 0
107107
#endif
108108

109-
// Set MRP retry intervals for Thread and Wi-Fi to test-proven values.
110109
#ifndef CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL
111-
#if CHIP_ENABLE_OPENTHREAD
112-
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (800_ms32)
113-
#else
110+
#ifndef CONFIG_NET_L2_OPENTHREAD
114111
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (1000_ms32)
115-
#endif // CHIP_ENABLE_OPENTHREAD
112+
#endif // CONFIG_NET_L2_OPENTHREAD
116113
#endif // CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL
117114

118115
#ifndef CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL
119-
#if CHIP_ENABLE_OPENTHREAD
120-
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (800_ms32)
121-
#else
116+
#ifndef CONFIG_NET_L2_OPENTHREAD
122117
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (1000_ms32)
123-
#endif // CHIP_ENABLE_OPENTHREAD
118+
#endif // CONFIG_NET_L2_OPENTHREAD
124119
#endif // CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL
125120

126121
#ifndef CHIP_CONFIG_ICD_IDLE_MODE_DURATION_SEC

0 commit comments

Comments
 (0)