applications: sdp: mspi: change opcode cast to uint32

Change cast of opcode in ep_recv function to uint32_t instead
of uint8_t.

Signed-off-by: Magdalena Pastula <magdalena.pastula@nordicsemi.no>

Author: magp-nordic

CODEOWNERS

@@ -346,6 +346,7 @@
 /include/drivers/flash/flash_ipuc.h       @nrfconnect/ncs-co-drivers @nrfconnect/ncs-charon
 /include/drivers/gpio/                    @nrfconnect/ncs-co-drivers @nrfconnect/ncs-ll-ursus
 /include/drivers/bme68x_iaq.h             @nrfconnect/ncs-co-drivers @nrfconnect/ncs-cia
+/include/drivers/mspi/nrf_mspi.h          @nrfconnect/ncs-co-drivers @nrfconnect/ncs-ll-ursus
 /include/drivers/mspi/nrfe_mspi.h         @nrfconnect/ncs-co-drivers @nrfconnect/ncs-ll-ursus
 /include/drivers/sensor_sim.h             @nrfconnect/ncs-co-drivers @nrfconnect/ncs-cia
 /include/drivers/sensor_stub.h            @nrfconnect/ncs-co-drivers @nrfconnect/ncs-cia

applications/sdp/mspi/src/main.c

@@ -423,8 +423,9 @@ static void ep_recv(const void *data, size_t len, void *priv)
 
 	(void)priv;
 	(void)len;
-	uint8_t opcode = *(uint8_t *)data;
+	uint32_t opcode = *(uint32_t *)data;
 	uint32_t num_bytes = 0;
+	uint32_t *resp_buff = (uint32_t *)response_buffer;
 
 #if defined(CONFIG_SDP_MSPI_FAULT_TIMER)
 	if (fault_timer != NULL) {
@@ -483,7 +484,8 @@ static void ep_recv(const void *data, size_t len, void *priv)
 		}
 
 		/* If there is reset defined on any data line, assume it is no longer valid and
-		 * clear it. */
+		 * clear it.
+		 */
 		if (dev_config->dev_config.io_mode != MSPI_IO_MODE_SINGLE &&
 		    reset_configs[dev_config->device_index].pin_number != PIN_UNUSED) {
 			nrf_vpr_csr_vio_out_clear_set(
@@ -545,7 +547,7 @@ static void ep_recv(const void *data, size_t len, void *priv)
 		break;
 	}
 
-	response_buffer[0] = opcode;
+	resp_buff[0] = opcode;
 	ipc_service_send(&ep, (const void *)response_buffer,
 			 sizeof(nrfe_mspi_opcode_t) + num_bytes);
 

drivers/mspi/mspi_nrfe.c

@@ -1063,13 +1063,12 @@ static int nrfe_mspi_init(const struct device *dev)
 }
 
 static const struct nrf_mspi_driver_api drv_api = {
-	.std_api =
-		{
-			.config = api_config,
-			.dev_config = api_dev_config,
-			.get_channel_status = api_get_channel_status,
-			.transceive = api_transceive,
-		},
+	.std_api = {
+		.config = api_config,
+		.dev_config = api_dev_config,
+		.get_channel_status = api_get_channel_status,
+		.transceive = api_transceive,
+	},
 	.reset_pin_config = api_reset_config,
 	.reset_pin_set = api_reset_set,
 };

include/drivers/mspi/nrf_mspi.h

@@ -28,16 +28,25 @@ __subsystem struct nrf_mspi_driver_api {
 };
 
 /**
- * @brief Configure reset pin. It is mandatory when reset pin overlaps with any data pin.
+ * @brief Configure reset pin. It should be used if there is a chance that reset pin overlaps with
+ * any data pin.
  *
- * @param dev pointer to the mspi device structure.
- * @param psel pin number
+ * Function checks if given reset pin overlap with any pin used by MSPI. If it does and can be used
+ * as reset in SINGLE mode (for example, ovelaps with data line DQ3), then it is saved in MSPI
+ * driver. If it does not overlap, then gpio_pin_configure_dt() is called.
  *
- * @retval non-negative the observed state of the on-off service associated
- *                      with the clock machine at the time the request was
- *                      processed (see onoff_release()), if successful.
- * @retval -EIO if service has recorded an error.
- * @retval -ENOTSUP if the service is not in a state that permits release.
+ * @param dev Pointer to the MSPI device structure.
+ * @param dev_id Pointer to the device ID of the MSPI device.
+ * @param spec GPIO specification from devicetree.
+ * @param gpio_port_num GPIO port number of the selected reset pin.
+ * @param extra_flags Additional GPIO flags.
+ *
+ * @retval 0 If successful.
+ * @retval -ENOTSUP Return value from gpio_pin_configure_dt().
+ * @retval -EINVAL If reset pin overlaps with MSPI pin that cannot be used as reset (e.g. CLK) or a
+ * return value from gpio_pin_configure_dt().
+ * @retval -EIO Return value from gpio_pin_configure_dt().
+ * @retval -EWOULDBLOCK Return value from gpio_pin_configure_dt().
  */
 static inline int nrf_mspi_reset_pin_config(const struct device *dev,
 					    const struct mspi_dev_id *dev_id,
@@ -50,16 +59,20 @@ static inline int nrf_mspi_reset_pin_config(const struct device *dev,
 }
 
 /**
- * @brief Set reset pin state.
+ * @brief Set reset pin state. It should be used if there is a chance that reset pin overlaps with
+ * any data pin.
+ *
+ * If reset pin does not overlap with any MSPI pin, gpio_pin_set_dt() is called.
+ * Assumes that nrf_mspi_reset_pin_config() was called before.
  *
- * @param dev pointer to the mspi device structure.
- * @param psel pin number
+ * @param dev Pointer to the MSPI device structure.
+ * @param spec GPIO specification from devicetree.
+ * @param dev_id Pointer to the device ID of the MSPI device.
+ * @param value Value assigned to the pin.
  *
- * @retval non-negative the observed state of the on-off service associated
- *                      with the clock machine at the time the request was
- *                      processed (see onoff_release()), if successful.
- * @retval -EIO if service has recorded an error.
- * @retval -ENOTSUP if the service is not in a state that permits release.
+ * @retval 0 If successful.
+ * @retval -EIO Return value from gpio_pin_set_dt().
+ * @retval -EWOULDBLOCK Return value from gpio_pin_set_dt().
  */
 static inline int nrf_mspi_reset_pin_set(const struct device *dev, const struct gpio_dt_spec *spec,
 					 const struct mspi_dev_id *dev_id, int value)