Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace src/bindings submodule with contents #2076

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

replace src/bindings submodule with contents #2076

wants to merge 5 commits into from

Conversation

Geometer1729
Copy link
Member

@Geometer1729 Geometer1729 commented Mar 11, 2025 •
edited
Loading

  • Replaces the o1js-bindings submodule with the same files but not as a submodle
  • merges CODEOWNERS files
  • changes linting rules to be consistent with previous behavior
  • Devex improvements (WIP)
    • When CI fails for either the npmDepsHash or the precompiled bindings you get an error like this
      image
    • The fix is pushed to a branch <your-branch>-ci-fix
    • Runing ./use-ci-fix.sh will merge the fix and delete the branch (I left pushing you you cause that feels aggressive)
      image

Closes #2080

@Geometer1729 Geometer1729 force-pushed the brian/remove-bindings-submodule branch 4 times, most recently from be8ac8c to 50a114b Compare March 12, 2025 16:18
@Geometer1729 Geometer1729 self-assigned this Mar 17, 2025
@Geometer1729 Geometer1729 force-pushed the brian/remove-bindings-submodule branch from 7dba623 to 831e125 Compare March 17, 2025 13:42
@Geometer1729 Geometer1729 mentioned this pull request Mar 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Geometer1729 Geometer1729

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get rid of o1js-bindings as submodule
1 participant
@Geometer1729