New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resampling in `match_extremes()` #11

Open

tomsail opened this issue Dec 10, 2024 · 2 comments

Contributor

tomsail commented Dec 10, 2024

the resampling should be deleted or at least be optional

Contributor Author

tomsail commented Dec 10, 2024

seastats/seastats/storms.py

Line 40 in 5194dfe

obs = obs.resample("1h").mean().shift(freq="30min")

Member

pmav99 commented Dec 10, 2024

I would say we should remove it. If the caller wants to resample he can do so outside of match_extremes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment