Skip to content

Commit 27a8552

Browse files
committed
Revert "fix(pkg): add default fallback and types export (#612)"
This reverts commit 069235f.
1 parent 1389b71 commit 27a8552

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

README.md

-3
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,6 @@ function myPlugin(octokit, options) {
7373
}
7474
```
7575

76-
> [!IMPORTANT]
77-
> As we use [conditional exports](https://nodejs.org/api/packages.html#conditional-exports), you will need to adapt your `tsconfig.json`. See the TypeScript docs on [package.json "exports"](https://www.typescriptlang.org/docs/handbook/modules/reference.html#packagejson-exports).
78-
7976
## `octokit.paginate()`
8077

8178
The `paginateRest` plugin adds a new `octokit.paginate()` method which accepts the same parameters as [`octokit.request`](https://github.com/octokit/request.js#request). Only "List ..." endpoints such as [List issues for a repository](https://developer.github.com/v3/issues/#list-issues-for-a-repository) are supporting pagination. Their [response includes a Link header](https://developer.github.com/v3/issues/#response-1). For other endpoints, `octokit.paginate()` behaves the same as `octokit.request()`.

scripts/build.mjs

+3-5
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,14 @@ async function main() {
6262
{
6363
...pkg,
6464
files: ["dist-*/**", "bin/**"],
65+
// Tooling currently are having issues with the "exports" field, ex: TypeScript, eslint
66+
// We add a `main` and `types` field to the package.json for the time being
67+
main: "dist-bundle/index.js",
6568
types: "dist-types/index.d.ts",
6669
exports: {
6770
".": {
6871
types: "./dist-types/index.d.ts",
6972
import: "./dist-bundle/index.js",
70-
// Tooling currently are having issues with the "exports" field when there is no "default", ex: TypeScript, eslint
71-
default: "./dist-bundle/index.js",
72-
},
73-
"./types": {
74-
types: "./dist-types/.d.ts",
7573
},
7674
},
7775
sideEffects: false,

0 commit comments

Comments
 (0)