You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As per the title, a bare-bones project using project.UI = WUI.WixUI_Common will display neither the background nor the banner image in the native dialogs. It does not matter if using the default ones, or custom ones set in project.BackgroundImage, BannerImage, and it does not matter whether the custom images are made into PNG, JPEG or BMP format, they simply won't display.
The issue can be apparently resolved, and the images displayed, by either adding <UIRef Id="WixUI_Common"/> to the WXS file, or adding project.WixSourceGenerated += doc => doc.Root.Select("Package").AddElement("UIRef", "Id=WixUI_Common"); in the Wix# code.
Turns out that Wix# has a lineproduct.AddElement("UIRef", $"Id={project.UI}"); for Wix3, but that line was dropped for Wix4. My question is what was the reason to drop it, and whether there would be any drawback in adding it back. Thank you.
The text was updated successfully, but these errors were encountered:
If I recall it right, the WiX4 upgrade wizard removed the UIRef tag. And indeed (I just retested) it is not required for any UI type. (e.g. project.UI = WUI.WixUI_Mondo). Tough WUI.WixUI_Common needs it when you create your custom dialogs. But until you do you cannot detect the problem since this UI has no dialogs by default. This is what you have discovered.
I think it is safe to reinstate it for WUI.WixUI_Common. Will make the change.
As per the title, a bare-bones project using
project.UI = WUI.WixUI_Common
will display neither the background nor the banner image in the native dialogs. It does not matter if using the default ones, or custom ones set inproject.BackgroundImage
,BannerImage
, and it does not matter whether the custom images are made into PNG, JPEG or BMP format, they simply won't display.The issue can be apparently resolved, and the images displayed, by either adding
<UIRef Id="WixUI_Common"/>
to the WXS file, or addingproject.WixSourceGenerated += doc => doc.Root.Select("Package").AddElement("UIRef", "Id=WixUI_Common");
in the Wix# code.Turns out that Wix# has a line
product.AddElement("UIRef", $"Id={project.UI}");
for Wix3, but that line was dropped for Wix4. My question is what was the reason to drop it, and whether there would be any drawback in adding it back. Thank you.The text was updated successfully, but these errors were encountered: