Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CameraSet, especially subsetting #111

Open
russelldj opened this issue Apr 25, 2024 · 2 comments
Open

Refactor CameraSet, especially subsetting #111

russelldj opened this issue Apr 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@russelldj
Copy link
Collaborator

This is mostly a note to revisit this later. The camera set object is a bit of a headache, especially when it comes to producing a subset of it. Especially for the derived SegmentorCameraSet, there's some weird edge cases where it returns the base image instead of the segmented one. Ideally, the only methods that are implemented in the camera set are ones that cannot be handled directly by the individual cameras. And subsetting should be handled in a clear and consistent manner across all derived classes.

@russelldj
Copy link
Collaborator Author

Specifically, if you use [] indexing notation on the SegmentorCameraSet, it will no longer perform segmentation. For this to work, __getitem__ would need to be implemented in the derived class.

@russelldj russelldj added the enhancement New feature or request label Jul 3, 2024
@russelldj
Copy link
Collaborator Author

This code is confusing and that's a big part of what we're trying to address here. One of the simplest ways we can think about this is we want to only use the self.cameras list. All of the lists of attributes starting here should be removed unless absolutely necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants