Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __str__ for major classes #21

Open
russelldj opened this issue Oct 31, 2023 · 6 comments
Open

Add __str__ for major classes #21

russelldj opened this issue Oct 31, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@russelldj
Copy link
Collaborator

It would help with debugging to be able to print out a string representation that contains some useful information. For example, what files the data is loaded from and the size of major data attributes. For example, number of vertices in a mesh or number of cameras in a set.

@russelldj russelldj added the good first issue Good for newcomers label Oct 31, 2023
@amitsgh
Copy link

amitsgh commented Oct 31, 2023

Subject: Request to work on issue

Dear @russelldj,
I'd like to work on above issue. Kindly consider assigning it to me.

Best Regards

@russelldj russelldj changed the title Add __str__ for major classe Add __str__ for major classes Nov 2, 2023
@russelldj
Copy link
Collaborator Author

Hi @amitsgh, Thanks for your interest in this! Please feel free to work on this and ask any questions you need. When you're ready, you can submit a PR with the changes.

You are our first external collaborator. I'll try to get some style guide documentation up for you, but generally we use black and isort as our main formatters. Also, we should probably get a Contributor License Agreement set up. I'll need to talk with @youngdjn about that, which may take a few days since he's currently out.

Out of curiosity, how did you find out about the project? Have you been able to run it?

@amitsgh
Copy link

amitsgh commented Nov 3, 2023

Hey @russelldj,

I am new to this open-source contribution thing, so I generally search issues label:'good first issue'. This is how I came across this repo.

I have read the readme file and checked the work on OFO website, thus decided to give it a try in contributing to it. I haven't set it up locally, but I will now, as I was waiting for the approval because I don't know how things generally works in open source.

@amitsgh
Copy link

amitsgh commented Nov 7, 2023

@russelldj, I am not clear on how to set it up locally, according to this https://github.com/open-forest-observatory/multiview-prediction-toolkit#installation, I current don't have access to /ofo-share.

@russelldj
Copy link
Collaborator Author

@amitsgh, sorry for the confusion. You don't need access to /ofo-share, it just is a simpler way to use the tool for internal OFO team members. You'll need to follow the steps for creating a new environment. I updated the documentation to make this clearer.

Currently, you won't have access to any of the example data. @youngdjn, do you have any thoughts about what we could use as publicly-available data or if we can send something to @amitsgh? I'm happy to take the conversation offline.

@russelldj
Copy link
Collaborator Author

We added some formatting guidelines here.

@amitsgh amitsgh removed their assignment Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants