Skip to content

Commit f9053b7

Browse files
authored
[chore] make: fix restart, add redeploy targets (#1397)
* fix restart, add redeploy Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix restart, add redeploy Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * use service or SERVICE Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
1 parent 6f38f5f commit f9053b7

File tree

3 files changed

+37
-23
lines changed

3 files changed

+37
-23
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ the release.
77

88
## Unreleased
99

10+
* [chore] fix Make targets for restart and redeploy
11+
([#1397](https://github.com/open-telemetry/opentelemetry-demo/pull/1397))
12+
1013
## 1.8.0
1114

1215
* [grafana] update grafana to 10.2.3

Makefile

+34-4
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,40 @@ stop:
164164
@echo ""
165165
@echo "OpenTelemetry Demo is stopped."
166166

167-
168-
# Use to rebuild and restart a single service component
167+
# Use to restart a single service component
169168
# Example: make restart service=frontend
170169
.PHONY: restart
171170
restart:
172-
# work with `service` or `SERVICE` as input
173-
./restart-service.sh ${service}${SERVICE}
171+
# work with `service` or `SERVICE` as input
172+
ifdef SERVICE
173+
service := $(SERVICE)
174+
endif
175+
176+
ifdef service
177+
docker compose stop $(service)
178+
docker compose rm --force $(service)
179+
docker compose create $(service)
180+
docker compose start $(service)
181+
else
182+
@echo "Please provide a service name using `service=[service name]` or `SERVICE=[service name]`"
183+
endif
184+
185+
# Use to rebuild and restart (redeploy) a single service component
186+
# Example: make redeploy service=frontend
187+
.PHONY: redeploy
188+
redeploy:
189+
# work with `service` or `SERVICE` as input
190+
ifdef SERVICE
191+
service := $(SERVICE)
192+
endif
193+
194+
ifdef service
195+
docker compose build $(service)
196+
docker compose stop $(service)
197+
docker compose rm --force $(service)
198+
docker compose create $(service)
199+
docker compose start $(service)
200+
else
201+
@echo "Please provide a service name using `service=[service name]` or `SERVICE=[service name]`"
202+
endif
203+

restart-service.sh

-19
This file was deleted.

0 commit comments

Comments
 (0)