jmx filter negative values in yaml #13589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation into jmx-filter-negative
robsunday
reviewed
Mar 28, 2025
...ibrary/src/main/java/io/opentelemetry/instrumentation/jmx/engine/BeanAttributeExtractor.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| protected Number extractNumericalAttribute( | ||
| MBeanServerConnection connection, ObjectName objectName) { | ||
| Number v = super.extractNumericalAttribute(connection, objectName); |
There was a problem hiding this comment.
Maybe you wanted to call extractor.extractNumericalAttribute(connection, objectName) instead of super. ?
There was a problem hiding this comment.
No, since we don't really delegate to the provided extractor, we just override the method implementation. I agree that it probably needs some refactor to simplify things a bit and make the implementation more clear.
| test1.negativeValues = false; | ||
| BeanAttributeExtractor rawExtractor = BeanAttributeExtractor.fromName(attributeName); | ||
| BeanAttributeExtractor filteringExtractor = | ||
| BeanAttributeExtractor.filterNegativeValues(rawExtractor); |
There was a problem hiding this comment.
[minor] Assuming you are going to do a real wrapping (see comment for filterNegativeValues) maybe it would be better to wrap some subtype of BeanAttributeExtractor, so we can be sure we do not call super.* method in wrapper class.
…nstrumentation into jmx-filter-negative
robsunday
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13461
Unblocks #13392
Adds a new
dropNegativeValuesattribute in YAML that enables to filter negative values which are commonly produced by MBean implementations to indicate metric is not available.