Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation missing for ignoreOutgoingRequestHook #5516

Open
jsumners-nr opened this issue Feb 28, 2025 · 1 comment
Open

Documentation missing for ignoreOutgoingRequestHook #5516

jsumners-nr opened this issue Feb 28, 2025 · 1 comment
Labels

Comments

@jsumners-nr
Copy link

jsumners-nr commented Feb 28, 2025

| `ignoreOutgoingRequestHook` | `IgnoreOutgoingRequestFunction` | Http instrumentation will not trace all outgoing requests that matched with custom function |

How is this setting supposed to be used? What are the parameters to the function? What is the function supposed to return? What do the return values indicate to the hook invoker?

@pichlermarc
Copy link
Member

I agree. All hooks in that instrumentation are in dire need of documentation.
There are lots of ways these can be used incorrectly too. We should also update the tsdoc for these as they are currently also very vague.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants