Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contribfest] use new get*FromEnv() functions in OTLP exporter shared env var configuration #5562

Open
4 tasks
pichlermarc opened this issue Mar 30, 2025 · 1 comment · May be fixed by #5583
Open
4 tasks
Assignees
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest

Comments

@pichlermarc
Copy link
Member

Description

Important

This issue is reserved for attendees of OpenTelemetry ContribFest at KubeCon EU 2025
If you are attending KubeCon EU 2025, please join us at Level 3 | ICC Capital Suite 1 on Wednesday April 2, 2025 16:15 - 17:30 BST 🙌

If you are not attending KubeCon EU 2025, the remainder of this issue will be
marked as "good-first-issue" starting Thursday. 🙂

With #5443 we've introduced new utility functions for getting getting environment variables in an OTel Spec compliant manner, and we've migrated from using the old getEnv() utility function. However, there are still some places which never used getEnv() at all as it was on it's way to being phased out, using process.env directly instead. The OTLP exporter configuration code is one of these places.

The goal of this issue is to replace usages of process.env.MY_ENV_VAR in the OTLP Exporter's shared configuration code (see here)

To complete this issue:

@pichlermarc pichlermarc added the contribfest These small and isolated issues are suitable for Kubecon Contribfest label Mar 30, 2025
@pichlermarc pichlermarc changed the title [contribfest] [contribfest] use new get*FromEnv() functions in OTLP exporter shared env var configuration [contribfest] use new get*FromEnv() functions in OTLP exporter shared env var configuration Mar 30, 2025
@weyert
Copy link
Contributor

weyert commented Apr 2, 2025

I will like to pick this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants