Make rc more informative

Searching for a given secret ID always means searching for an ID of a
given secret type (AES-128-KEY, AES-192-KEY, HMAC-SHA-256-KEY, etc.).
If this fails, there are two possible reasons: there is no secret
with the given ID in the system, or the given ID belongs to a secret
with another type. Therefore make the related rc and its description
more informative.

Signed-off-by: Joerg Schmidbauer <jschmidb@de.ibm.com>

Author: jschmidb

include/zpc/error.h

@@ -482,10 +482,10 @@ extern "C" {
 # define ZPC_ERROR_PVSECRET_TYPE_NOT_SUPPORTED         79
 
 /**
- * \def ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV
- * \brief the given pvsecret ID does not belong to a secret on this system.
+ * \def ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV_OR_INVALID_TYPE
+ * \brief the given pvsecret ID does either not exist or belongs to a different secret type.
  */
-# define ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV         80
+# define ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV_OR_INVALID_TYPE         80
 
 /**
  * \def ZPC_ERROR_IOCTLVERIFYKEY2

src/aes_key.c

@@ -695,7 +695,7 @@ zpc_aes_key_import(struct zpc_aes_key *aes_key, const unsigned char *buf,
 		}
 	} else {
 		if (aes_key_blob_is_valid_pvsecret_id(aes_key, buf) != 0) {
-			rc = ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV;
+			rc = ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV_OR_INVALID_TYPE;
 			goto ret;
 		}
 	}

src/ecc_key.c

@@ -678,7 +678,7 @@ int zpc_ec_key_import(struct zpc_ec_key *ec_key, const unsigned char *buf,
 
 	if (ec_key->type == ZPC_EC_KEY_TYPE_PVSECRET) {
 		if (ec_key_blob_is_valid_pvsecret_id(ec_key, buf) != 0) {
-			rc = ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV;
+			rc = ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV_OR_INVALID_TYPE;
 			goto ret;
 		}
 	}

src/hmac_key.c

@@ -493,7 +493,7 @@ int zpc_hmac_key_import(struct zpc_hmac_key *hmac_key, const unsigned char *buf,
 	}
 
 	if (hmac_key_blob_is_valid_pvsecret_id(hmac_key, buf) != 0) {
-		rc = ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV;
+		rc = ZPC_ERROR_PVSECRET_ID_NOT_FOUND_IN_UV_OR_INVALID_TYPE;
 		goto ret;
 	}