fix: return value of Event.stopPropagation() should be undefined

andycall · wssgcg1213 · commit 6fc38ecece93 · 2021-05-07T19:23:09.000+08:00
diff --git a/bridge/bindings/jsc/DOM/event.cc b/bridge/bindings/jsc/DOM/event.cc
@@ -176,7 +176,7 @@ JSValueRef JSEvent::stopPropagation(JSContextRef ctx, JSObjectRef function, JSOb
                                                    JSValueRef *exception) {
   auto eventInstance = static_cast<EventInstance *>(JSObjectGetPrivate(thisObject));
   eventInstance->_propagationStopped = true;
-  return nullptr;
+  return JSValueMakeUndefined(ctx);
 }
 
 JSValueRef JSEvent::stopImmediatePropagation(JSContextRef ctx, JSObjectRef function,

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ JSValueRef JSEvent::stopPropagation(JSContextRef ctx, JSObjectRef function, JSOb`
`176`	`176`	`JSValueRef *exception) {`
`177`	`177`	`auto eventInstance = static_cast<EventInstance *>(JSObjectGetPrivate(thisObject));`
`178`	`178`	`eventInstance->_propagationStopped = true;`
`179`		`- return nullptr;`
	`179`	`+ return JSValueMakeUndefined(ctx);`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`JSValueRef JSEvent::stopImmediatePropagation(JSContextRef ctx, JSObjectRef function,`