From a7122ad7c79f607960bcf44e910bee8ad04a2810 Mon Sep 17 00:00:00 2001 From: Alexis Daboville Date: Wed, 12 Apr 2023 10:12:28 +0100 Subject: [PATCH] Rename metric from .p50 to .median as we (internally) denylist .p50 suffixes (#260) Rename time to first bind metric from p50 to median --- internal/metrics/metrics.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/metrics/metrics.go b/internal/metrics/metrics.go index 7e0f51e6..76f98cc6 100644 --- a/internal/metrics/metrics.go +++ b/internal/metrics/metrics.go @@ -53,7 +53,7 @@ const ( unboundMemoryReservations = "foundry.spark.scheduler.reservations.unbound.memory" unboundNvidiaGPUReservations = "foundry.spark.scheduler.reservations.unbound.nvidiagpu" timeToFirstBind = "foundry.spark.scheduler.reservations.timetofirstbind" - timeToFirstBindP50 = "foundry.spark.scheduler.reservations.timetofirstbind.p50" + timeToFirstBindMedian = "foundry.spark.scheduler.reservations.timetofirstbind.median" timeToFirstBindMean = "foundry.spark.scheduler.reservations.timetofirstbind.mean" softReservationCount = "foundry.spark.scheduler.softreservation.count" softReservationExecutorCount = "foundry.spark.scheduler.softreservation.executorcount" @@ -372,6 +372,6 @@ func IncrementSingleAzDynamicAllocationPackFailure(ctx context.Context, zone str func ReportTimeToFirstBindMetrics(ctx context.Context, duration time.Duration) { timeToFirstBindHist := metrics.FromContext(ctx).Histogram(timeToFirstBind) timeToFirstBindHist.Update(duration.Nanoseconds()) - metrics.FromContext(ctx).GaugeFloat64(timeToFirstBindP50).Update(timeToFirstBindHist.Percentile(.5)) + metrics.FromContext(ctx).GaugeFloat64(timeToFirstBindMedian).Update(timeToFirstBindHist.Percentile(.5)) metrics.FromContext(ctx).GaugeFloat64(timeToFirstBindMean).Update(timeToFirstBindHist.Mean()) }