Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: Don't display technical credential names to end users -- specifically in notifications #3158

Open
lebraat opened this issue Dec 27, 2024 · 1 comment

Comments

@lebraat
Copy link
Member

lebraat commented Dec 27, 2024

User Story:

As a user reviewing my notifications
I want to see human-readable credential names
So that I can better understand what the notification relates to

Acceptance Criteria

GIVEN an expiration notification about a credential
WHEN A user tries to read it
THEN they read a human-readable notification, rather than our technical credential name.

In general, we should audit our entire user-facing app and footprint to ensure that we are not displaying our technical credential names to users, and instead, delivering human-readable credential names.

If you need support coming up with human-readable credential names, please let me (Daniel) know.

@Jkd-eth Jkd-eth moved this to Prioritized in Passport New Jan 2, 2025
@Jkd-eth Jkd-eth changed the title Don't display technical credential names to end users -- specifically in notifications Notifications: Don't display technical credential names to end users -- specifically in notifications Jan 2, 2025
@nutrina
Copy link
Collaborator

nutrina commented Jan 13, 2025

If we fix this, it would not apply retroactively for notifications already stored in the DB.
But we could just remove the unread notifications, and this will cause them to be regenerated when the user logs in the next time (if the condition still exist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Prioritized
Development

No branches or pull requests

2 participants