Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed: refactor identity package #3176

Open
4 tasks
nutrina opened this issue Jan 10, 2025 · 0 comments · May be fixed by #3182
Open
4 tasks

Embed: refactor identity package #3176

nutrina opened this issue Jan 10, 2025 · 0 comments · May be fixed by #3182
Assignees
Labels
Embed Passport Embed Product

Comments

@nutrina
Copy link
Collaborator

nutrina commented Jan 10, 2025

The identity package in the passport repo handles:

  • issuing of VCs - this is a backend functionality, that is used in the IAM
  • fetching VCs - this functionality is used in the app, and it basically performs an http reuqest with axios to claim VCs from the iam

The fact that we have functionality for the app in there makes it hard to extend this module with additional features that are related to validation / issuance of stamps in backend services.

Tasks

  • move all app related functionality (fetchVerifiableCredential and its helpers) into the app. This means the identity module will only be used in the backend.
  • consolidate stamp verification and issuance into the identity module:
    • this means code that was performing validating of stamps in iam and embed should be consolidate (remove redundancies) and moved here
  • update implementation in iam to use the new functionality in the identity module
  • update implementation in embed to use the new functionality in the identity module

Ideally the package dependencies should look like:

flowchart TD
    A[Iam] -->|stamp verification/issuance| I[identity]
    E[embed] -->|stamp verification/issuance| I
    I -->|stamp providers| P[Platforms]
    U[app] -->|stamp & provider declaration & metadata| P
    U -->|ceramic| F[database-client]
    U -->|type definitions| T[types]
    A -->|type definitions| T
    E -->|type definitions| T
    P -->|type definitions| T
    I -->|type definitions| T

Loading
@nutrina nutrina converted this from a draft issue Jan 10, 2025
@Jkd-eth Jkd-eth added the Embed Passport Embed Product label Jan 14, 2025
@nutrina nutrina moved this from Prioritized to In Progress (WIP) in Passport New Jan 15, 2025
@nutrina nutrina self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embed Passport Embed Product
Projects
Status: In Progress (WIP)
Development

Successfully merging a pull request may close this issue.

2 participants