fix: throw error if setting ice attributes fails

achingbrain · achingbrain · commit 41f4d883e8ca · 2024-06-13T16:55:55.000+01:00
diff --git a/src/impl/icetransport.cpp b/src/impl/icetransport.cpp
@@ -141,7 +141,9 @@ IceTransport::IceTransport(const Configuration &config, candidate_callback candi
 }
 
 void IceTransport::setIceAttributes(string uFrag, string pwd) {
-	juice_set_local_ice_attributes(mAgent.get(), uFrag.c_str(), pwd.c_str());
+	if (juice_set_local_ice_attributes(mAgent.get(), uFrag.c_str(), pwd.c_str()) < 0) {
+		throw std::invalid_argument("Invalid ICE attributes");
+	}
 }
 
 void IceTransport::addIceServer(IceServer server) {

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,9 @@ IceTransport::IceTransport(const Configuration &config, candidate_callback candi`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`void IceTransport::setIceAttributes(string uFrag, string pwd) {`
`144`		`- juice_set_local_ice_attributes(mAgent.get(), uFrag.c_str(), pwd.c_str());`
	`144`	`+ if (juice_set_local_ice_attributes(mAgent.get(), uFrag.c_str(), pwd.c_str()) < 0) {`
	`145`	`+ throw std::invalid_argument("Invalid ICE attributes");`
	`146`	`+ }`
`145`	`147`	`}`
`146`	`148`
`147`	`149`	`void IceTransport::addIceServer(IceServer server) {`