forked from elastic/elastic-agent
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathlog_level_test.go
392 lines (332 loc) · 16.2 KB
/
log_level_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
// or more contributor license agreements. Licensed under the Elastic License;
// you may not use this file except in compliance with the Elastic License.
//go:build integration
package integration
import (
"bytes"
"context"
"encoding/json"
"fmt"
"io"
"net/http"
"strings"
"testing"
"text/template"
"time"
"github.com/google/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/elastic/elastic-agent-libs/kibana"
"github.com/elastic/elastic-agent-libs/logp"
"github.com/elastic/elastic-agent/pkg/control/v2/cproto"
"github.com/elastic/elastic-agent/pkg/core/logger"
atesting "github.com/elastic/elastic-agent/pkg/testing"
"github.com/elastic/elastic-agent/pkg/testing/define"
"github.com/elastic/elastic-agent/pkg/testing/tools/fleettools"
"github.com/elastic/elastic-agent/pkg/testing/tools/testcontext"
"github.com/elastic/elastic-agent/pkg/utils"
)
func TestSetLogLevelFleetManaged(t *testing.T) {
info := define.Require(t, define.Requirements{
Group: Fleet,
Stack: &define.Stack{},
Sudo: true,
})
deadline := time.Now().Add(10 * time.Minute)
ctx, cancel := testcontext.WithDeadline(t, context.Background(), deadline)
defer cancel()
f, err := define.NewFixtureFromLocalBuild(t, define.Version())
require.NoError(t, err, "failed creating agent fixture")
policyResp, enrollmentTokenResp := createPolicyAndEnrollmentToken(ctx, t, info.KibanaClient, createBasicPolicy())
t.Logf("Created policy %+v", policyResp.AgentPolicy)
t.Log("Getting default Fleet Server URL...")
fleetServerURL, err := fleettools.DefaultURL(ctx, info.KibanaClient)
require.NoError(t, err, "failed getting Fleet Server URL")
installOutput, err := f.Install(ctx, &atesting.InstallOpts{
NonInteractive: true,
Force: true,
EnrollOpts: atesting.EnrollOpts{
URL: fleetServerURL,
EnrollmentToken: enrollmentTokenResp.APIKey,
},
})
assert.NoErrorf(t, err, "Error installing agent. Install output:\n%s\n", string(installOutput))
require.Eventuallyf(t, func() bool {
return waitForAgentAndFleetHealthy(ctx, t, f)
}, time.Minute, time.Second, "agent never became healthy or connected to Fleet")
// get the agent ID
agentID, err := getAgentID(ctx, f)
require.NoError(t, err, "error getting the agent ID")
testLogLevelSetViaFleet(ctx, f, agentID, t, info, policyResp)
}
func testLogLevelSetViaFleet(ctx context.Context, f *atesting.Fixture, agentID string, t *testing.T, info *define.Info, policyResp kibana.PolicyResponse) {
// Step 0: get the initial log level reported by agent
initialLogLevel, err := getLogLevelFromInspectOutput(ctx, f)
require.NoError(t, err, "error retrieving agent log level")
assert.Equal(t, logger.DefaultLogLevel.String(), initialLogLevel, "unexpected default log level at agent startup")
// Step 1: set a different log level in Fleet policy
policyLogLevel := logp.ErrorLevel
t.Logf("Setting policy log level to %q", policyLogLevel.String())
// make sure we are changing something
require.NotEqualf(t, logger.DefaultLogLevel, policyLogLevel, "Policy log level %s should be different than agent default log level", policyLogLevel)
// set policy log level and verify that eventually the agent sets it
err = updatePolicyLogLevel(ctx, t, info.KibanaClient, policyResp.AgentPolicy, policyLogLevel.String())
require.NoError(t, err, "error updating policy log level")
// assert `elastic-agent inspect` eventually reports the new log level
// TODO re-enable inspect assertion after https://github.com/elastic/elastic-agent/issues/4870 is solved
//assert.Eventuallyf(t, func() bool {
// agentLogLevel, err := getLogLevelFromInspectOutput(ctx, f)
// if err != nil {
// t.Logf("error getting log level from agent: %v", err)
// return false
// }
// t.Logf("Agent log level: %q policy log level: %q", agentLogLevel, policyLogLevel)
// return agentLogLevel == policyLogLevel.String()
//}, 30*time.Second, time.Second, "agent never received expected log level %q", policyLogLevel)
// assert Fleet eventually receives the new log level from agent through checkin
assert.Eventuallyf(t, func() bool {
fleetMetadataLogLevel, err := getLogLevelFromFleetMetadata(ctx, t, info.KibanaClient, agentID)
if err != nil {
t.Logf("error getting log level for agent %q from Fleet metadata: %v", agentID, err)
return false
}
t.Logf("Fleet metadata log level for agent %q: %q policy log level: %q", agentID, fleetMetadataLogLevel, policyLogLevel)
return fleetMetadataLogLevel == policyLogLevel.String()
}, 30*time.Second, time.Second, "agent never communicated policy log level %q to Fleet", policyLogLevel)
// Step 2: set a different log level for the specific agent using Settings action
// set agent log level and verify that it takes precedence over the policy one
agentLogLevel := logp.DebugLevel.String()
t.Logf("Setting agent log level to %q", agentLogLevel)
err = updateAgentLogLevel(ctx, t, info.KibanaClient, agentID, agentLogLevel)
require.NoError(t, err, "error updating agent log level")
// TODO re-enable inspect assertion after https://github.com/elastic/elastic-agent/issues/4870 is solved
//assert.Eventuallyf(t, func() bool {
// actualAgentLogLevel, err := getLogLevelFromInspectOutput(ctx, f)
// if err != nil {
// t.Logf("error getting log level from agent: %v", err)
// return false
// }
// t.Logf("Agent log level: %q, expected level: %q", actualAgentLogLevel, agentLogLevel)
// return actualAgentLogLevel == agentLogLevel
//}, 2*time.Minute, time.Second, "agent never received agent-specific log level %q", agentLogLevel)
// assert Fleet eventually receives the new log level from agent through checkin
assert.Eventuallyf(t, func() bool {
fleetMetadataLogLevel, err := getLogLevelFromFleetMetadata(ctx, t, info.KibanaClient, agentID)
if err != nil {
t.Logf("error getting log level for agent %q from Fleet metadata: %v", agentID, err)
return false
}
t.Logf("Fleet metadata log level for agent %q: %q agent log level: %q", agentID, fleetMetadataLogLevel, agentLogLevel)
return fleetMetadataLogLevel == agentLogLevel
}, 30*time.Second, time.Second, "agent never communicated agent-specific log level %q to Fleet", agentLogLevel)
// Step 3: Clear the agent-specific log level override, verify that we revert to policy log level
t.Logf("Clearing agent log level, expecting log level to revert back to %q", policyLogLevel)
err = updateAgentLogLevel(ctx, t, info.KibanaClient, agentID, "")
require.NoError(t, err, "error clearing agent log level")
// assert `elastic-agent inspect` eventually reports the new log level
// TODO re-enable inspect assertion after https://github.com/elastic/elastic-agent/issues/4870 is solved
//assert.Eventuallyf(t, func() bool {
// actualAgentLogLevel, err := getLogLevelFromInspectOutput(ctx, f)
// if err != nil {
// t.Logf("error getting log level from agent: %v", err)
// return false
// }
// t.Logf("Agent log level: %q policy log level: %q", actualAgentLogLevel, policyLogLevel)
// return actualAgentLogLevel == policyLogLevel.String()
//}, 30*time.Second, time.Second, "agent never reverted to policy log level %q", policyLogLevel)
// assert Fleet eventually receives the new log level from agent through checkin
assert.Eventuallyf(t, func() bool {
fleetMetadataLogLevel, err := getLogLevelFromFleetMetadata(ctx, t, info.KibanaClient, agentID)
if err != nil {
t.Logf("error getting log level for agent %q from Fleet metadata: %v", agentID, err)
return false
}
t.Logf("Fleet metadata log level for agent %q: %q policy log level: %q", agentID, fleetMetadataLogLevel, policyLogLevel)
return fleetMetadataLogLevel == policyLogLevel.String()
}, 30*time.Second, time.Second, "agent never communicated reverting to policy log level %q to Fleet", policyLogLevel)
// Step 4: Clear the log level in policy and verify that agent reverts to the initial log level
t.Logf("Clearing policy log level, expecting log level to revert back to %q", initialLogLevel)
err = updatePolicyLogLevel(ctx, t, info.KibanaClient, policyResp.AgentPolicy, "")
require.NoError(t, err, "error clearing policy log level")
// assert `elastic-agent inspect` eventually reports the initial log level
// TODO re-enable inspect assertion after https://github.com/elastic/elastic-agent/issues/4870 is solved
//assert.Eventuallyf(t, func() bool {
// actualAgentLogLevel, err := getLogLevelFromInspectOutput(ctx, f)
// if err != nil {
// t.Logf("error getting log level from agent: %v", err)
// return false
// }
// t.Logf("Agent log level: %q initial log level: %q", actualAgentLogLevel, initialLogLevel)
// return actualAgentLogLevel == initialLogLevel
//}, 2*time.Minute, time.Second, "agent never reverted to initial log level %q", initialLogLevel)
// assert Fleet eventually receives the new log level from agent through checkin
assert.Eventuallyf(t, func() bool {
fleetMetadataLogLevel, err := getLogLevelFromFleetMetadata(ctx, t, info.KibanaClient, agentID)
if err != nil {
t.Logf("error getting log level for agent %q from Fleet metadata: %v", agentID, err)
return false
}
t.Logf("Fleet metadata log level for agent %q: %q initial log level: %q", agentID, fleetMetadataLogLevel, initialLogLevel)
return fleetMetadataLogLevel == initialLogLevel
}, 30*time.Second, time.Second, "agent never communicated initial log level %q to Fleet", initialLogLevel)
}
func waitForAgentAndFleetHealthy(ctx context.Context, t *testing.T, f *atesting.Fixture) bool {
status, err := f.ExecStatus(ctx)
if err != nil {
t.Logf("error fetching agent status: %v", err)
return false
}
statusBuffer := new(strings.Builder)
err = json.NewEncoder(statusBuffer).Encode(status)
if err != nil {
t.Logf("error marshaling agent status: %v", err)
} else {
t.Logf("agent status: %v", statusBuffer.String())
}
return status.State == int(cproto.State_HEALTHY) && status.FleetState == int(cproto.State_HEALTHY)
}
func updateAgentLogLevel(ctx context.Context, t *testing.T, kibanaClient *kibana.Client, agentID string, logLevel string) error {
updateLogLevelTemplateString := `{
"action": {
"type": "SETTINGS",
"data": {
"log_level": {{ .logLevel }}
}
}
}`
updateLogLevelTemplate, err := template.New("updatePolicyLogLevel").Parse(updateLogLevelTemplateString)
if err != nil {
return fmt.Errorf("error parsing update log level request template: %w", err)
}
buf := new(bytes.Buffer)
templateData := map[string]string{}
if logLevel != "" {
templateData["logLevel"] = `"` + logLevel + `"`
} else {
templateData["logLevel"] = "null"
}
err = updateLogLevelTemplate.Execute(buf, templateData)
t.Logf("Updating agent-specific log level to %q", logLevel)
_, err = kibanaClient.SendWithContext(ctx, http.MethodPost, "/api/fleet/agents/"+agentID+"/actions", nil, nil, buf)
if err != nil {
return fmt.Errorf("error executing fleet request: %w", err)
}
// The log below is a bit spammy but it can be useful for debugging
//respDump, err := httputil.DumpResponse(fleetResp, true)
//if err != nil {
// t.Logf("Error dumping Fleet response to updating agent-specific log level: %v", err)
//} else {
// t.Logf("Fleet response to updating agent-specific log level:\n----- BEGIN RESPONSE DUMP -----\n%s\n----- END RESPONSE DUMP -----\n", string(respDump))
//}
return nil
}
func updatePolicyLogLevel(ctx context.Context, t *testing.T, kibanaClient *kibana.Client, policy kibana.AgentPolicy, newPolicyLogLevel string) error {
// The request we would need is the one below, but at the time of writing there is no way to set overrides with fleet api definition in elastic-agent-libs, need to update
// info.KibanaClient.UpdatePolicy(ctx, policyResp.ID, kibana.AgentPolicyUpdateRequest{})
// Let's do a generic HTTP request
updateLogLevelTemplateString := `{
"name": "{{ .policyName }}",
"namespace": "{{ .namespace }}",
"advanced_settings": {
"agent_logging_level": {{ .logLevel }}
}
}`
updateLogLevelTemplate, err := template.New("updatePolicyLogLevel").Parse(updateLogLevelTemplateString)
if err != nil {
return fmt.Errorf("error parsing update log level request template: %w", err)
}
buf := new(bytes.Buffer)
templateData := map[string]string{"policyName": policy.Name, "namespace": policy.Namespace}
if newPolicyLogLevel == "" {
// to reset the log level we have to set it to null
templateData["logLevel"] = "null"
} else {
templateData["logLevel"] = `"` + newPolicyLogLevel + `"`
}
err = updateLogLevelTemplate.Execute(buf, templateData)
if err != nil {
return fmt.Errorf("error rendering policy update template: %w", err)
}
_, err = kibanaClient.SendWithContext(ctx, http.MethodPut, "/api/fleet/agent_policies/"+policy.ID, nil, nil, buf)
if err != nil {
return fmt.Errorf("error executing fleet request: %w", err)
}
// The log below is a bit spammy but it can be useful for debugging
//respDump, err := httputil.DumpResponse(fleetResp, true)
//if err != nil {
// t.Logf("Error dumping Fleet response to updating policy log level: %v", err)
//} else {
// t.Logf("Fleet response to updating policy log level:\n----- BEGIN RESPONSE DUMP -----\n%s\n----- END RESPONSE DUMP -----\n", string(respDump))
//}
return nil
}
func getAgentID(ctx context.Context, f *atesting.Fixture) (string, error) {
agentInspectOutput, err := f.ExecInspect(ctx)
if err != nil {
return "", fmt.Errorf("executing elastic-agent inspect: %w", err)
}
return agentInspectOutput.Agent.ID, nil
}
func getLogLevelFromInspectOutput(ctx context.Context, f *atesting.Fixture) (string, error) {
agentInspectOutput, err := f.ExecInspect(ctx)
if err != nil {
return "", fmt.Errorf("executing elastic-agent inspect: %w", err)
}
return agentInspectOutput.Agent.Logging.Level, nil
}
func getLogLevelFromFleetMetadata(ctx context.Context, t *testing.T, kibanaClient *kibana.Client, agentID string) (string, error) {
// The request we would need is kibanaClient.GetAgent(), but at the time of writing there is no way to get loglevel with fleet api definition in elastic-agent-libs, need to update
// kibana.AgentCommon struct to pick up log level from `local_metadata`
// Let's do a generic HTTP request
response, err := kibanaClient.SendWithContext(ctx, http.MethodGet, "/api/fleet/agents/"+agentID, nil, nil, nil)
if err != nil {
return "", fmt.Errorf("getting agent from Fleet: %w", err)
}
defer response.Body.Close()
// The log below is a bit spammy but it can be useful for debugging
//dumpResponse, err := httputil.DumpResponse(response, true)
//if err != nil {
// t.Logf(" error dumping agent metadata fleet response: %v", err)
//} else {
// t.Logf("agent metadata fleet response:\n----- BEGIN RESPONSE DUMP -----\n%s\n----- END RESPONSE DUMP -----", dumpResponse)
//}
responseBodyBytes, err := io.ReadAll(response.Body)
if err != nil {
return "", fmt.Errorf("reading response body from Fleet: %w", err)
}
rawJson := map[string]any{}
err = json.Unmarshal(responseBodyBytes, &rawJson)
if err != nil {
return "", fmt.Errorf("unmarshalling Fleet response: %w", err)
}
rawLogLevel, err := utils.GetNestedMap(rawJson, "item", "local_metadata", "elastic", "agent", "log_level")
if err != nil {
return "", fmt.Errorf("looking for item/local_metadata/elastic/agent/log_level key in Fleet response: %w", err)
}
if logLevel, ok := rawLogLevel.(string); ok {
return logLevel, nil
}
return "", fmt.Errorf("loglevel from Fleet output is not a string: %T", rawLogLevel)
}
func createPolicyAndEnrollmentToken(ctx context.Context, t *testing.T, kibClient *kibana.Client, policy kibana.AgentPolicy) (kibana.PolicyResponse, kibana.CreateEnrollmentAPIKeyResponse) {
t.Log("Creating Agent policy...")
policyResp, err := kibClient.CreatePolicy(ctx, policy)
require.NoError(t, err, "failed creating policy")
t.Log("Creating Agent enrollment API key...")
createEnrollmentApiKeyReq := kibana.CreateEnrollmentAPIKeyRequest{
PolicyID: policyResp.ID,
}
enrollmentToken, err := kibClient.CreateEnrollmentAPIKey(ctx, createEnrollmentApiKeyReq)
require.NoError(t, err, "failed creating enrollment API key")
return policyResp, enrollmentToken
}
func createBasicPolicy() kibana.AgentPolicy {
policyUUID := uuid.New().String()
return kibana.AgentPolicy{
Name: "testloglevel-policy-" + policyUUID,
Namespace: "default",
Description: "Test Log Level Policy " + policyUUID,
MonitoringEnabled: []kibana.MonitoringEnabledOption{},
}
}