Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BlFontSize? #604

Open
tinchodias opened this issue Sep 24, 2024 · 1 comment
Open

Remove BlFontSize? #604

tinchodias opened this issue Sep 24, 2024 · 1 comment
Labels

Comments

@tinchodias
Copy link
Collaborator

Bloc-Text pacjage extends Number as shown here:
Screenshot 2024-09-24 at 19 40 40
These methods are unsend and the class is unreferenced.

Additionally, the superclass of BlFontSize is BlValueWithUnit and this works on collaboration with a hierarchy of units:
Screenshot 2024-09-24 at 19 43 38

Instead of removing them... This could be a base for features we mentioned recently with @labordep or @ELePors or maybe @Nyan11

@labordep
Copy link
Contributor

@tinchodias it should be great to choose the font unit, actually we are converting our size from pt to px or from em to px and this is not practice because there is always some difference with the original design (for example in Figma or Illustrator), I don't know why, may be due to OS/UI/Font, etc. I don't know how to do better for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants