constraint feature bugfix (2.3.63 release) (#599)

* fix bug where creating a custom constraint for parameters within features was not correctly identifying the constrained parameter and was raising an error when attempting to set the value of the constraining parameter.

Author: kecnry

README.md

@@ -84,6 +84,10 @@ To understand how to use PHOEBE, please consult the [tutorials, scripts and manu
 CHANGELOG
 ----------
 
+### 2.3.63 - constraint feature bugfix
+
+* fix bug where creating a custom constraint for parameters within features was not correctly identifying the constrained parameter and was raising an error when attempting to set the value of the constraining parameter.
+
 ### 2.3.62 - attach_job ferr bugfix
 
 * fix bug where error file was not properly loaded when retrieving error from external job

phoebe/__init__.py

@@ -17,7 +17,7 @@
 
 """
 
-__version__ = '2.3.62'
+__version__ = '2.3.63'
 
 import os as _os
 import sys as _sys

phoebe/parameters/parameters.py

@@ -11331,7 +11331,7 @@ def _update_bookkeeping(self):
         self._remove_bookkeeping()
         # logger.debug("ConstraintParameter {} _update_bookkeeping".format(self.twig))
         for param in self.vars.to_list():
-            if param.qualifier == self.qualifier and param.component == self.component and param.dataset == self.dataset:
+            if param.qualifier == self.qualifier and param.component == self.component and param.dataset == self.dataset and param.feature == self.feature:
                 # then this is the currently constrained parameter
                 param._is_constraint = self.uniqueid
                 if self.uniqueid in param._in_constraints:
@@ -11342,7 +11342,7 @@ def _update_bookkeeping(self):
                     param._in_constraints.append(self.uniqueid)
 
         for param in self.addl_vars.to_list():
-            if param.qualifier == self.qualifier and param.component == self.component and param.dataset == self.dataset:
+            if param.qualifier == self.qualifier and param.component == self.component and param.dataset == self.dataset and param.feature == self.feature:
                 # then this is the currently constrained parameter
                 param._is_constraint = self.uniqueid
 

setup.py

@@ -405,8 +405,8 @@ def _env_variable_bool(key, default):
     long_description = "\n".join(long_description_s[long_description_s.index("INTRODUCTION"):])
 
 setup (name = 'phoebe',
-       version = '2.3.62',
-       description = 'PHOEBE 2.3.62',
+       version = '2.3.63',
+       description = 'PHOEBE 2.3.63',
        long_description=long_description,
        author = 'PHOEBE development team',
        author_email = 'phoebe-devel@lists.sourceforge.net',
@@ -426,7 +426,7 @@ def _env_variable_bool(key, default):
             'Programming Language :: Python :: 3 :: Only',
         ],
        python_requires='>=3.6, <4',
-       download_url = 'https://github.com/phoebe-project/phoebe2/tarball/2.3.62',
+       download_url = 'https://github.com/phoebe-project/phoebe2/tarball/2.3.63',
        packages = ['phoebe', 'phoebe.parameters', 'phoebe.parameters.solver', 'phoebe.parameters.figure', 'phoebe.frontend', 'phoebe.constraints', 'phoebe.dynamics', 'phoebe.distortions', 'phoebe.algorithms', 'phoebe.atmospheres', 'phoebe.backend', 'phoebe.solverbackends', 'phoebe.solverbackends.ebai', 'phoebe.utils', 'phoebe.helpers', 'phoebe.pool', 'phoebe.dependencies', 'phoebe.dependencies.autofig', 'phoebe.dependencies.nparray', 'phoebe.dependencies.distl', 'phoebe.dependencies.unitsiau2015'],
        install_requires=['numpy>=1.12','scipy>=1.2','astropy>=1.0', 'corner', 'pytest', 'requests', 'python-socketio[client]']+['flask', 'flask-cors', 'flask-socketio==4.3.*', 'gevent-websocket'],
        package_data={'phoebe.atmospheres':['tables/wd/*', 'tables/passbands/*'],