Merge pull request #3 from php-static-analysis/codex/update-php-static-analysis-dependencies-to-0.5.0

carlos-granados · web-flow · commit 16c3b971afb1 · 2025-06-04T18:07:46.000+02:00
feat: store attribute parameters
diff --git a/composer.json b/composer.json
@@ -27,14 +27,14 @@
     "prefer-stable": true,
     "require": {
         "php": ">=8.1",
-        "php-static-analysis/attributes": "^0.4.1 || dev-main",
-        "php-static-analysis/node-visitor": "^0.4.1 || dev-main",
+        "php-static-analysis/attributes": "^0.5.0 || dev-main",
+        "php-static-analysis/node-visitor": "^0.5.0 || dev-main",
         "rector/rector": "^2.0"
     },
     "require-dev": {
         "composer/composer": "^2.8",
-        "php-static-analysis/phpstan-extension": "^0.4.1 || dev-main",
-        "php-static-analysis/psalm-plugin": "^0.4.1 || dev-main",
+        "php-static-analysis/phpstan-extension": "^0.5.0 || dev-main",
+        "php-static-analysis/psalm-plugin": "^0.5.0 || dev-main",
         "phpstan/extension-installer": "^1.3",
         "phpstan/phpstan": "^2.0",
         "phpunit/phpunit": "^9.0",
diff --git a/psalm.xml b/psalm.xml
@@ -7,6 +7,7 @@
         errorLevel="1"
         findUnusedBaselineEntry="true"
         findUnusedCode="false"
+        ensureOverrideAttribute="false"
 >
     <projectFiles>
         <directory name="src" />
diff --git a/src/AnnotationsToAttributesRector.php b/src/AnnotationsToAttributesRector.php
@@ -68,7 +68,6 @@
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
-/** @psalm-suppress PropertyNotSetInConstructor */
 final class AnnotationsToAttributesRector extends AbstractRector implements ConfigurableRectorInterface, MinPhpVersionInterface
 {
     #[Type('AnnotationToAttribute[]')]
diff --git a/src/AttributesToAnnotationsRector.php b/src/AttributesToAnnotationsRector.php
@@ -23,7 +23,6 @@
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
-/** @psalm-suppress PropertyNotSetInConstructor */
 final class AttributesToAnnotationsRector extends AbstractRector implements RectorInterface, MinPhpVersionInterface
 {
     private AttributeNodeVisitor $nodeVisitor;
diff --git a/src/Composer/Plugin.php b/src/Composer/Plugin.php
@@ -9,7 +9,7 @@
 use Composer\Script\Event;
 use PhpStaticAnalysis\Attributes\Returns;
 
-class Plugin implements PluginInterface, EventSubscriberInterface
+final class Plugin implements PluginInterface, EventSubscriberInterface
 {
     public function activate(Composer $composer, IOInterface $io)
     {
diff --git a/tests/AttributesToAnnotationsToAttributesRectorTest.php b/tests/AttributesToAnnotationsToAttributesRectorTest.php
@@ -14,6 +14,17 @@ final class AttributesToAnnotationsToAttributesRectorTest extends AbstractRector
      */
     public function test(string $filePath): void
     {
+        $fileName = basename($filePath);
+        $this->expectOutputString(
+            <<<TXT
+
+WARNING: On fixture file "$fileName" for test "test\PhpStaticAnalysis\RectorRule\AttributesToAnnotationsToAttributesRectorTest"
+File not changed but some Rector rules applied:
+ * PhpStaticAnalysis\RectorRule\AnnotationsToAttributesRector
+ * PhpStaticAnalysis\RectorRule\AttributesToAnnotationsRector
+
+TXT
+        );
         $this->doTestFile($filePath);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`errorLevel="1"`
`8`	`8`	`findUnusedBaselineEntry="true"`
`9`	`9`	`findUnusedCode="false"`
	`10`	`+ ensureOverrideAttribute="false"`
`10`	`11`	`>`
`11`	`12`	`<projectFiles>`
`12`	`13`	`<directory name="src" />`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,6 @@`
`68`	`68`	`use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;`
`69`	`69`	`use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;`
`70`	`70`
`71`		`-/** @psalm-suppress PropertyNotSetInConstructor */`
`72`	`71`	`final class AnnotationsToAttributesRector extends AbstractRector implements ConfigurableRectorInterface, MinPhpVersionInterface`
`73`	`72`	`{`
`74`	`73`	`#[Type('AnnotationToAttribute[]')]`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@`
`23`	`23`	`use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;`
`24`	`24`	`use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;`
`25`	`25`
`26`		`-/** @psalm-suppress PropertyNotSetInConstructor */`
`27`	`26`	`final class AttributesToAnnotationsRector extends AbstractRector implements RectorInterface, MinPhpVersionInterface`
`28`	`27`	`{`
`29`	`28`	`private AttributeNodeVisitor $nodeVisitor;`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`use Composer\Script\Event;`
`10`	`10`	`use PhpStaticAnalysis\Attributes\Returns;`
`11`	`11`
`12`		`-class Plugin implements PluginInterface, EventSubscriberInterface`
	`12`	`+final class Plugin implements PluginInterface, EventSubscriberInterface`
`13`	`13`	`{`
`14`	`14`	`public function activate(Composer $composer, IOInterface $io)`
`15`	`15`	`{`